Fix chocolatey package build scripts #1949
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
dslomov
suggested changes
Oct 16, 2016
| @@ -16,7 +16,7 @@ write-host @" | |||
| The package should have installed without errors. | |||
|
|
|||
| Now: | |||
| * open an msys2 shell | |||
| * open a new shell (this should work in msys2, cmd, powershell) | |||
| * Make sure your environment is accurate (see ``./tools/chocolateyinstall.ps1`` output) | |||
| * run ``bazel version`` in that msys2 shell | |||
added 5 commits
October 17, 2016 21:10
Otherwise repeated runs just accrete into it
|
@dslomov I think this is now ready for re-review. I've submitted the package to chocolatey and am back in their queue too. |
|
@dslomov ping? |
|
Sorry for delay, I am on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moderator fed back; corrected issues. Thanks @gep13!