Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RCs with chocolatey package #2005

Closed
wants to merge 8 commits into from
Closed

Support RCs with chocolatey package #2005

wants to merge 8 commits into from

Conversation

petemounce
Copy link
Contributor

@petemounce petemounce commented Oct 28, 2016 •
edited
Loading

@meteorcloudy (from #1902) This

  • makes the tools/*.ps1 generation more sane
  • supports generating a package for RCs

I have had a successful local install, but I want to see what chocolatey's test automation makes of this.

You can see that at https://chocolatey.org/packages/bazel/0.4.0-rc3.

Once it has been approved, it should be possible to install with choco install bazel --prerelease or update via choco upgrade bazel --prerelease.

Peter Mounce added 4 commits October 28, 2016 22:18
Externalise configuration to remove need for templating
c9818f4
Fix wording
be33664
Improve test automation
9da3f69
Support publishing release candidates
2ede86c 
Note that this would be much faster (and simpler) if the sha256 file of the zip were available within the google bucket.
This generates a package whose version should be `x.y.z-rc<number>`
@bazel-io
Copy link
Member

Can one of the admins verify this patch?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@petemounce petemounce changed the title Support RCs (don't merge yet) Support RCs with chocolatey package Oct 28, 2016
dslomov
dslomov suggested changes Oct 29, 2016
View reviewed changes
scripts/packages/chocolatey/build.ps1
}
if ($checksum -eq "") {
write-host "calculating checksum"
# $tvChecksum = (get-filehash $tvFilename -algorithm sha256).Hash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 12fd8aa.

dslomov
dslomov approved these changes Oct 29, 2016
View reviewed changes
Copy link
Contributor

@dslomov dslomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this

@petemounce
Copy link
Contributor Author

Thanks :)

@laszlocsomor
Copy link
Contributor

@dslomov : please close the PR when this is merged. Thanks!

@petemounce
Copy link
Contributor Author

@dslomov ping? I'd like to be able to release 0.4.0's chocolatey package, which needs this and the zip to be present in GH releases. I checked the google storage bucket that the RCs are in, and it's not there; looks like RCs only.

@dslomov
Copy link
Contributor

dslomov commented Nov 2, 2016

yes sorry the merge got stuck on this side (funnily enough we have an
internal leak detector that's supposed to not let us leak super-secret
google information and it triggered on your changes :))
I'll follow up on zip files not being available as well.

On Wed, Nov 2, 2016 at 8:57 PM, Peter Mounce notifications@github.com
wrote:

@dslomov https://github.com/dslomov ping? I'd like to be able to
release 0.4.0's chocolatey package, which needs this and the zip to be
present in GH releases. I checked the google storage bucket that the RCs
are in, and it's not there; looks like RCs only.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2005 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AExrX2zvXrSp0ka4MVXwdmr-KWMuzGZiks5q6OsWgaJpZM4Kj9DP
.

Google Germany GmbH
Erika-Mann-Straße 33, 80636 München, Germany

@petemounce
Copy link
Contributor Author

@dslomov re: leak detector - that's really funny.

re: zip files - thanks.

@bazel-io bazel-io closed this in f9fa89f Nov 3, 2016
steren pushed a commit to bazelbuild/bazel-website that referenced this pull request Apr 26, 2017
@laszlocsomor
Support RCs with chocolatey package
effae81 
This
- makes the `tools/*.ps1` generation more sane
- supports generating a package for RCs

Closes #2005.

--
Reviewed-on: bazelbuild/bazel#2005
MOS_MIGRATED_REVID=138052483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dslomov dslomov dslomov approved these changes

Assignees

@dslomov dslomov

Labels
cla: no
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@petemounce @bazel-io @googlebot @laszlocsomor @dslomov