[JSON Trace Profile] Correctly identify GC thread #20299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the thread that includes the garbace colleciton notification events is not correctly identified. This means that in the JSON trace profile, the thread: * is not renamed, as desired. * is not sorted towards the top, as desired. The thread is identified by its name, which has changed from "Service Thread" to "Notification Thread". This change updates the profile code accordingly. In response to bazelbuild#18548 (comment)
github-actions
bot
added
team-Performance
|
@meisterT Here's a suggested patch for #18548 (comment) |
|
@tjgq Can you also take a look at this one? |
This would also be good to get into 7, as it fixes another regression. |
|
@bazel-io flag |
tjgq
approved these changes
Nov 27, 2023
|
@bazel-io fork 7.0.0 |
keertk
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Nov 27, 2023
Currently, the thread that includes the garbage collection notification events is not correctly identified. This means that in the JSON trace profile, the thread: * is not renamed, as desired. * is not sorted towards the top, as desired. The thread is identified by its name, which has changed from "Service Thread" to "Notification Thread". This change updates the profile code accordingly. In response to bazelbuild#18548 (comment) Fixes EngFlow/bazel_invocation_analyzer#110 Closes bazelbuild#20299. PiperOrigin-RevId: 585639069 Change-Id: Id4aadb5451839b5be07ac98428f9367764ff46ce
keertk
pushed a commit
that referenced
this pull request
Nov 27, 2023
Currently, the thread that includes the garbage collection notification events is not correctly identified. This means that in the JSON trace profile, the thread: * is not renamed, as desired. * is not sorted towards the top, as desired. The thread is identified by its name, which has changed from "Service Thread" to "Notification Thread". This change updates the profile code accordingly. In response to #18548 (comment) Fixes EngFlow/bazel_invocation_analyzer#110 Closes #20299. Commit 13829ed PiperOrigin-RevId: 585639069 Change-Id: Id4aadb5451839b5be07ac98428f9367764ff46ce Co-authored-by: Sara Adams <sara@engflow.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the thread that includes the garbace colleciton notification events is not correctly identified.
This means that in the JSON trace profile, the thread:
The thread is identified by its name, which has changed from "Service Thread" to "Notification Thread". This change updates the profile code accordingly.
In response to #18548 (comment)
Fixes EngFlow/bazel_invocation_analyzer#110