Fix chocolatey package hard-coding c: drive #2046
Conversation
|
Can one of the admins verify this patch? |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
Ping @laszlocsomor. |
|
Once the 0.4.0 package has been approved, I'll push this change onto it. If I push it now, the package goes to the back of the queue. |
| @@ -50,7 +50,7 @@ if ($packageParameters) | |||
| } | |||
| Install-ChocolateyPath -PathToInstall "$msys2Path\usr\bin" -PathType "Machine" | |||
|
|
|||
| $addToMsysPath = ($packageDir -replace 'c:\\','/c/') -replace '\\','/' | |||
| $addToMsysPath = ($packageDir -replace '^([a-zA-Z]):\\(.*)','/$1/$2') -replace '\\','/' | |||
There was a problem hiding this comment.
I think you don't need to match $2 if you're outputting it unaltered.
There was a problem hiding this comment.
That's true. I like this pattern more since it's more explicit, but I don't feel strongly.
There was a problem hiding this comment.
LGTM
EDIT: I meant this for commit 64db96f
Still need to get used to GitHub's review UI.
|
I'll import this PR now |
This fixes #2032.