Add remote output service proto #21140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
coeuvre
force-pushed
the
remote_output_service
branch
from
db9fa3e
to
8a247c5
Compare
|
Hey! Would you want me to continue posting feedback in the document, or should I put it in the PR going forward? |
sgowroji
added
the
team-Remote-Exec
|
Let's continue the review here! |
EdSchouten
reviewed
Feb 2, 2024
tjgq
requested changes
Feb 6, 2024
EdSchouten
reviewed
Feb 7, 2024
|
@EdSchouten @tjgq Sorry for the delay, I just had a long vacation. I have updated the PR, please take another look! |
EdSchouten
approved these changes
Mar 4, 2024
tjgq
approved these changes
Mar 5, 2024
EdSchouten
reviewed
Mar 6, 2024
EdSchouten
reviewed
Mar 6, 2024
EdSchouten
reviewed
Mar 6, 2024
|
FYI: I just finished a change to reimplement bb_clientd on top of this new protocol. I'll make sure to publish it as soon as this PR gets merged. |
EdSchouten
approved these changes
Mar 6, 2024
coeuvre
force-pushed
the
remote_output_service
branch
from
c75ffaf
to
0b6cefa
Compare
github-actions
bot
removed
the
awaiting-review
|
@coeuvre Should this be cherry-picked into 7.x? |
|
The plan is to cherry-pick both the protocol and client code into 7.2. |
EdSchouten
added a commit
to buildbarn/bb-remote-execution
that referenced
this pull request
Mar 6, 2024
Google has merged a change for adding the Remote Output Service protocol to their code base: bazelbuild/bazel#21140. They did however make a couple of changes to it. For example: - The protocol has been made REv2 agnostic. All explicit coupling to REv2 has been moved into a helper protocol. - BatchCreate() has been renamed to StageArtifacts(). It can only be used to create files and directories. Not symlinks. It also doesn't provide options to clean directories. This is likely going to hurt runfiles directory creation, but we'll see whether that is actually a problem in practice. - BatchStat() no longer provides follow_symlinks and include_file_digests. Symlinks are no longer followed, and file digests should always be included. - There is a FinalizeArtifacts() function. This function can be used to reliably implement file modification tracking. As we don't implement that yet, we can simply let it be a stub for the time being.
EdSchouten
added a commit
to buildbarn/bb-remote-execution
that referenced
this pull request
Mar 6, 2024
Google has merged a change for adding the Remote Output Service protocol to their code base: bazelbuild/bazel#21140. They did however make a couple of changes to it. For example: - The protocol has been made REv2 agnostic. All explicit coupling to REv2 has been moved into a helper protocol. - BatchCreate() has been renamed to StageArtifacts(). It can only be used to create files and directories. Not symlinks. It also doesn't provide options to clean directories. This is likely going to hurt runfiles directory creation, but we'll see whether that is actually a problem in practice. - BatchStat() no longer provides follow_symlinks and include_file_digests. Symlinks are no longer followed, and file digests should always be included. - There is a FinalizeArtifacts() function. This function can be used to reliably implement file modification tracking. As we don't implement that yet, we can simply let it be a stub for the time being.
EdSchouten
added a commit
to buildbarn/bb-clientd
that referenced
this pull request
Mar 6, 2024
Google has merged a change for adding the Remote Output Service protocol to their code base: bazelbuild/bazel#21140. They did however make a couple of changes to it. For example: - The protocol has been made REv2 agnostic. All explicit coupling to REv2 has been moved into a helper protocol. - BatchCreate() has been renamed to StageArtifacts(). It can only be used to create files and directories. Not symlinks. It also doesn't provide options to clean directories. This is likely going to hurt runfiles directory creation, but we'll see whether that is actually a problem in practice. - BatchStat() no longer provides follow_symlinks and include_file_digests. Symlinks are no longer followed, and file digests should always be included. - There is a FinalizeArtifacts() function. This function can be used to reliably implement file modification tracking. As we don't implement that yet, we can simply let it be a stub for the time being.
|
@bazel-io fork 7.2.0 |
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Mar 25, 2024
Working towards bazelbuild#20933. Closes bazelbuild#21140. PiperOrigin-RevId: 613219486 Change-Id: Ie4e02e04e2dcfc444234fb164a73865edf8d9ba0
iancha1992
added a commit
that referenced
this pull request
Mar 26, 2024
|
The changes in this PR have been included in Bazel 7.2.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards #20933.