Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the python dependency more lenient #2122

Closed
wants to merge 5 commits into from
Closed

Make the python dependency more lenient #2122

wants to merge 5 commits into from

Conversation

petemounce
Copy link
Contributor

Based on this comment, allow python3 to be used. cc @meteorcloudy.

@bazel-io
Copy link
Member

Can one of the admins verify this patch?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@@ -77,7 +77,7 @@ Supply like `--params="/option:value ..."` ([see docs for --params](https://gith
<dependencies>
<dependency id="jdk8" version="[8.0.102,)"/>
<dependency id="msys2" version="[20160719.1,)"/>
<dependency id="python2" version="[2.7.11,3.0)"/>
<dependency id="python2" version="[2.7.11,)"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the id to python only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes; excellent point! Done in 2a147e5.

@meteorcloudy meteorcloudy self-assigned this Nov 23, 2016
@meteorcloudy
Copy link
Member

LGTM, thanks!

@petemounce
Copy link
Contributor Author

Cool. I'll publish 0.4.1 RCs built from this, unless you can think of a reason not to.

Peter Mounce added 2 commits November 23, 2016 15:23
@petemounce
Copy link
Contributor Author

Couple more changes to the chocolatey build/test scripts incoming.

@petemounce
Copy link
Contributor Author

@meteorcloudy Please take another look?

@bazel-io bazel-io closed this in ad13a9c Nov 23, 2016
@@ -77,7 +77,7 @@ Supply like `--params="/option:value ..."` ([see docs for --params](https://gith
<dependencies>
<dependency id="jdk8" version="[8.0.102,)"/>
<dependency id="msys2" version="[20160719.1,)"/>
<dependency id="python2" version="[2.7.11,3.0)"/>
<dependency id="python" version="[2.7.11,)"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petemounce this is effectively the same as version="2.7.11" - it just means 2.7.11 is the minimum version that can be installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants