-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the python dependency more lenient #2122
Make the python dependency more lenient #2122
Conversation
Can one of the admins verify this patch? |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@@ -77,7 +77,7 @@ Supply like `--params="/option:value ..."` ([see docs for --params](https://gith | |||
<dependencies> | |||
<dependency id="jdk8" version="[8.0.102,)"/> | |||
<dependency id="msys2" version="[20160719.1,)"/> | |||
<dependency id="python2" version="[2.7.11,3.0)"/> | |||
<dependency id="python2" version="[2.7.11,)"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the id to python
only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes; excellent point! Done in 2a147e5.
LGTM, thanks! |
Cool. I'll publish 0.4.1 RCs built from this, unless you can think of a reason not to. |
Based on [this comment](#2027 (comment)), allow python3 to be used
Couple more changes to the chocolatey build/test scripts incoming. |
(Previously, the zip+checksum were not published with RCs)
@meteorcloudy Please take another look? |
@@ -77,7 +77,7 @@ Supply like `--params="/option:value ..."` ([see docs for --params](https://gith | |||
<dependencies> | |||
<dependency id="jdk8" version="[8.0.102,)"/> | |||
<dependency id="msys2" version="[20160719.1,)"/> | |||
<dependency id="python2" version="[2.7.11,3.0)"/> | |||
<dependency id="python" version="[2.7.11,)"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petemounce this is effectively the same as version="2.7.11"
- it just means 2.7.11 is the minimum version that can be installed.
Based on this comment, allow python3 to be used. cc @meteorcloudy.