Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve missing local_jdk error message #21392

Closed
wants to merge 1 commit into from
Closed

Improve missing local_jdk error message #21392

wants to merge 1 commit into from
+16 −3

Conversation

keith
Copy link
Member

@keith keith commented Feb 16, 2024

This slightly improves #21391

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Feb 16, 2024
@keith keith mentioned this pull request Feb 16, 2024
Closed
@sgowroji sgowroji added the team-Rules-Java Issues for Java rules label Feb 19, 2024
@keith
Copy link
Member Author

keith commented Feb 20, 2024

the test here is flaky and unrelated AFAICT, I think someone is looking at it

@keith keith force-pushed the ks/improve-missing-local_jdk-error-message branch from 5c9dac5 to fc5038a Compare February 23, 2024 19:35
hvadehra
hvadehra previously approved these changes Feb 26, 2024
View reviewed changes
@hvadehra hvadehra added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-review PR is awaiting review from an assigned reviewer awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally labels Feb 26, 2024
hvadehra
hvadehra reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@hvadehra hvadehra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure seems relevant?

https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/018de48a-d132-4cfa-a308-f6da1bfe1d9b/src/test/shell/bazel/bazel_embedded_starlark_test/test.log

@keith
Copy link
Member Author

keith commented Feb 28, 2024

im just going to drop this since we got to the bottom of the core issue. i imagine there is an issue here that it's sidestepping without this change

@keith keith closed this Feb 28, 2024
@keith keith deleted the ks/improve-missing-local_jdk-error-message branch February 28, 2024 22:01
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Feb 28, 2024
hvadehra added a commit that referenced this pull request May 8, 2024
@hvadehra
Improve errors in integration tests when the local jdk is not found
c09eaee 
Related:

#21392

#22228
@hvadehra hvadehra mentioned this pull request May 8, 2024
Closed
hvadehra added a commit that referenced this pull request May 8, 2024
@hvadehra
Improve errors in integration tests when the local jdk is not found
1a630b0 
Related:

#21392

#22228
@hvadehra hvadehra mentioned this pull request May 8, 2024
Closed
copybara-service bot pushed a commit that referenced this pull request May 14, 2024
@hvadehra
Improve errors in integration tests when the local jdk is not found
905a4fe 
Related:

#21391 / #21392

#22228

Closes #22285.

PiperOrigin-RevId: 633466127
Change-Id: I6334c655607807073da2eda88b1fe66a81fb8ba7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvadehra hvadehra hvadehra left review comments

Assignees
No one assigned
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keith @hvadehra @sgowroji