Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.2.0] Register CommandProfilerModule early. #21611

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

tjgq
Copy link
Contributor

@tjgq tjgq commented Mar 7, 2024

So that the profile includes time spent in the beforeCommand for other modules.

PiperOrigin-RevId: 613582228
Change-Id: I9e8d0e7712005ad408346ce0a852b9e5ac313193

@tjgq tjgq requested a review from a team as a code owner March 7, 2024 18:25
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Mar 7, 2024
@Wyverald
Copy link
Member

Wyverald commented Mar 7, 2024

We just pushed rc2, which I was hoping would be the last rc for 7.1.0. How important is this cherry-pick? I'd rather we didn't push out 7.1.0 even further. (Of course, if we have a regression that requires rc3, this can go in no problem.)

@iancha1992 iancha1992 added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Mar 7, 2024
@keertk
Copy link
Member

keertk commented Mar 25, 2024

@tjgq the release-7.2.0 branch is ready. Want to resend this PR?

So that the profile includes time spent in the beforeCommand for other modules.

PiperOrigin-RevId: 613582228
Change-Id: I9e8d0e7712005ad408346ce0a852b9e5ac313193
@tjgq tjgq changed the base branch from release-7.1.0 to release-7.2.0 March 25, 2024 15:56
@tjgq tjgq changed the title [7.1.0] Register CommandProfilerModule early. [7.2.0] Register CommandProfilerModule early. Mar 25, 2024
@tjgq
Copy link
Contributor Author

tjgq commented Mar 25, 2024

@tjgq the release-7.2.0 branch is ready. Want to resend this PR?

Rebased.

@keertk keertk enabled auto-merge (squash) March 25, 2024 15:57
@keertk keertk self-requested a review March 25, 2024 15:57
@keertk keertk added this to the 7.2.0 release blockers milestone Mar 25, 2024
@keertk keertk merged commit 51f869e into bazelbuild:release-7.2.0 Mar 25, 2024
32 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants