[7.1.1] Fix race condition and add more logging for null entry error message #21692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to address NPE reported in: bazelbuild/bazel-skylib#488 (comment) and bazelbuild#21665 (comment) The `put()` call to the runfiles dir map is placed before the call that stashes the corresponding directory to address the race condition described here: bazelbuild/bazel-skylib#488 (comment). The exception will now log: - entries in the runfiles dir map - environment variables - stashes on disk Closes bazelbuild#21668. PiperOrigin-RevId: 615739651 Change-Id: Ida90e334d1d1f890cf204d272134726bb1f70eb9
bazel-io
added
team-Local-Exec
oquenchil
approved these changes
Mar 14, 2024
Merged
via the queue into
bazelbuild:release-7.1.1
with commit Mar 14, 2024
49166bd
33 checks passed
github-actions
bot
removed
the
awaiting-review
iancha1992
pushed a commit
that referenced
this pull request
Mar 21, 2024
Baseline: 9b39cca Release Notes: + Release 7.1.0 (2024-03-11) + Update centos7 platform in build_bazel_binaries.yml (#21644) + Fix `bazel mod tidy` failure with no changes (#21662) + Update .bazelversion to 7.1.0 (#21664) + Let native Turbine image find `ct.sym` with non-hermetic `java_runtime` (#21670) + Actually use shouldPublish() to determine whether to publish the execution log to the BEP. (#21671) + Also inject a failure for createWritableDirectory when testing that ActionOutputDirectoryHelper propagates exceptions. (#21683) + Fix race condition and add more logging for null entry error message (#21692) + Allow any canonical repo name to be used with `bazel mod show_repo` (#21694) + Fix two `bazel mod tidy` crashes (#21700) + Cherry-pick Java execution info improvements (#21703) + Disable //src/test/shell/bazel:srcs_test on Intel macOS (#21707) + Fix sandbox cleanup crashing after server restart (#21733) + Revert "Fix `bazel fetch` by replacing query with cquery for … (#21735) Acknowledgements: This release contains contributions from many people at Google, as well as bazel.build machine account, Fabian Meumertzheim, Xùdōng Yáng.
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
Baseline: 9b39cca Release Notes: + Release 7.1.0 (2024-03-11) + Update centos7 platform in build_bazel_binaries.yml (#21644) + Fix `bazel mod tidy` failure with no changes (#21662) + Update .bazelversion to 7.1.0 (#21664) + Let native Turbine image find `ct.sym` with non-hermetic `java_runtime` (#21670) + Actually use shouldPublish() to determine whether to publish the execution log to the BEP. (#21671) + Also inject a failure for createWritableDirectory when testing that ActionOutputDirectoryHelper propagates exceptions. (#21683) + Fix race condition and add more logging for null entry error message (#21692) + Allow any canonical repo name to be used with `bazel mod show_repo` (#21694) + Fix two `bazel mod tidy` crashes (#21700) + Cherry-pick Java execution info improvements (#21703) + Disable //src/test/shell/bazel:srcs_test on Intel macOS (#21707) + Fix sandbox cleanup crashing after server restart (#21733) + Revert "Fix `bazel fetch` by replacing query with cquery for … (#21735) Acknowledgements: This release contains contributions from many people at Google, as well as bazel.build machine account, Fabian Meumertzheim, Xùdōng Yáng.
iancha1992
pushed a commit
that referenced
this pull request
Mar 21, 2024
Baseline: 9b39cca Release Notes: + Release 7.1.0 (2024-03-11) + Update centos7 platform in build_bazel_binaries.yml (#21644) + Fix `bazel mod tidy` failure with no changes (#21662) + Update .bazelversion to 7.1.0 (#21664) + Let native Turbine image find `ct.sym` with non-hermetic `java_runtime` (#21670) + Actually use shouldPublish() to determine whether to publish the execution log to the BEP. (#21671) + Also inject a failure for createWritableDirectory when testing that ActionOutputDirectoryHelper propagates exceptions. (#21683) + Fix race condition and add more logging for null entry error message (#21692) + Allow any canonical repo name to be used with `bazel mod show_repo` (#21694) + Fix two `bazel mod tidy` crashes (#21700) + Cherry-pick Java execution info improvements (#21703) + Disable //src/test/shell/bazel:srcs_test on Intel macOS (#21707) + Fix sandbox cleanup crashing after server restart (#21733) + Revert "Fix `bazel fetch` by replacing query with cquery for … (#21735) Acknowledgements: This release contains contributions from many people at Google, as well as bazel.build machine account, Fabian Meumertzheim, Xùdōng Yáng.
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
Baseline: 9b39cca Release Notes: + Release 7.1.0 (2024-03-11) + Update centos7 platform in build_bazel_binaries.yml (#21644) + Fix `bazel mod tidy` failure with no changes (#21662) + Update .bazelversion to 7.1.0 (#21664) + Let native Turbine image find `ct.sym` with non-hermetic `java_runtime` (#21670) + Actually use shouldPublish() to determine whether to publish the execution log to the BEP. (#21671) + Also inject a failure for createWritableDirectory when testing that ActionOutputDirectoryHelper propagates exceptions. (#21683) + Fix race condition and add more logging for null entry error message (#21692) + Allow any canonical repo name to be used with `bazel mod show_repo` (#21694) + Fix two `bazel mod tidy` crashes (#21700) + Cherry-pick Java execution info improvements (#21703) + Disable //src/test/shell/bazel:srcs_test on Intel macOS (#21707) + Fix sandbox cleanup crashing after server restart (#21733) + Revert "Fix `bazel fetch` by replacing query with cquery for … (#21735) Acknowledgements: This release contains contributions from many people at Google, as well as bazel.build machine account, Fabian Meumertzheim, Xùdōng Yáng.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to address NPE reported in: bazelbuild/bazel-skylib#488 (comment) and #21665 (comment)
The
put()call to the runfiles dir map is placed before the call that stashes the corresponding directory to address the race condition described here: bazelbuild/bazel-skylib#488 (comment).The exception will now log:
Closes #21668.
Commit 59dbf7a
PiperOrigin-RevId: 615739651
Change-Id: Ida90e334d1d1f890cf204d272134726bb1f70eb9