Clean up cc_shared_library runfiles test
#21880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
added
team-Rules-CPP
github-actions
bot
added
the
awaiting-review
fmeum
force-pushed
the
21833-runfiles-test
branch
from
2454115
to
c6eb344
Compare
pzembrod
approved these changes
Apr 12, 2024
|
@bazel-io fork 7.2.0 |
|
@pzembrod Do you want me to resolve the conflict in |
pzembrod
added
awaiting-PR-merge
|
@fmeum Thanks for the awaiting-merge reminder; done. |
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Apr 19, 2024
Simplifies the test of `cc_shared_library`'s runfiles behavior using new rules_testing features, which also result in better failure messages. Also format `BUILD.builtin_test` with buildifier to simplify future contributions. Work towards bazelbuild#21833 Closes bazelbuild#21880. PiperOrigin-RevId: 626315579 Change-Id: Ib7b3d1367586ba7215132d6a9f3711f4ae0a9b09
sgowroji
removed
the
awaiting-PR-merge
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Apr 26, 2024
Simplifies the test of `cc_shared_library`'s runfiles behavior using new rules_testing features, which also result in better failure messages. Also format `BUILD.builtin_test` with buildifier to simplify future contributions. Work towards bazelbuild#21833 Closes bazelbuild#21880. PiperOrigin-RevId: 626315579 Change-Id: Ib7b3d1367586ba7215132d6a9f3711f4ae0a9b09
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
May 10, 2024
Simplifies the test of `cc_shared_library`'s runfiles behavior using new rules_testing features, which also result in better failure messages. Also format `BUILD.builtin_test` with buildifier to simplify future contributions. Work towards bazelbuild#21833 Closes bazelbuild#21880. PiperOrigin-RevId: 626315579 Change-Id: Ib7b3d1367586ba7215132d6a9f3711f4ae0a9b09
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
Simplifies the test of `cc_shared_library`'s runfiles behavior using new rules_testing features, which also result in better failure messages. Also format `BUILD.builtin_test` with buildifier to simplify future contributions. Work towards bazelbuild#21833 Closes bazelbuild#21880. PiperOrigin-RevId: 626315579 Change-Id: Ib7b3d1367586ba7215132d6a9f3711f4ae0a9b09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the test of
cc_shared_library's runfiles behavior using new rules_testing features, which also result in better failure messages.Also format
BUILD.builtin_testwith buildifier to simplify future contributions.Work towards #21833