Handle file type changes with in-process symlink creation #22087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SymlinkTreeUpdater` now correctly replaces symlinks with directories and vice versa in runfiles trees.
github-actions
bot
added
the
awaiting-review
iancha1992
added
the
team-Rules-Server
tjgq
requested changes
Apr 24, 2024
src/main/java/com/google/devtools/build/lib/exec/SymlinkTreeHelper.java
Outdated
Show resolved
Hide resolved
tjgq
approved these changes
Apr 24, 2024
tjgq
added
awaiting-PR-merge
|
@bazel-io fork 7.2.0 |
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Apr 25, 2024
`SymlinkTreeUpdater` now correctly replaces symlinks with directories and vice versa in runfiles trees. Fixes bazelbuild#20266 Closes bazelbuild#22087. PiperOrigin-RevId: 628028591 Change-Id: Id94cea42f9cdfab001e56242a329b8d6d253ba29
sgowroji
removed
the
awaiting-PR-merge
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
`SymlinkTreeUpdater` now correctly replaces symlinks with directories and vice versa in runfiles trees. Fixes bazelbuild#20266 Closes bazelbuild#22087. PiperOrigin-RevId: 628028591 Change-Id: Id94cea42f9cdfab001e56242a329b8d6d253ba29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SymlinkTreeUpdaternow correctly replaces symlinks with directories and vice versa in runfiles trees.Fixes #20266