cquery: Factor RepositoryName into fetching ignored packages #22142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Performance
Previously this code was assuming that all cquery target patterns should use the root repository's .bazelignore contents which was incorrect. Because the way this manifested itself was that when cquery drives populating the graph and when it queries it, it would use different keys, this led to misleading messages about packages not being in scope.
illicitonion
force-pushed
the
cquery-external-bazelignore
branch
from
863eb21
to
1898224
Compare
|
cc @gregestren - this PR is ~trivial if you have a moment :) |
katre
approved these changes
Apr 26, 2024
|
Nice catch. I was curious what the actual error is, so I ran just the new test in Bazel at HEAD: Definitely a fix we should merge.. |
katre
added
type: bug
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
Previously this code was assuming that all cquery target patterns should use the root repository's .bazelignore contents which was incorrect. Because the way this manifested itself was that when cquery drives populating the graph and when it queries it, it would use different keys, this led to misleading messages about packages not being in scope. Closes bazelbuild#22142. PiperOrigin-RevId: 628477138 Change-Id: I84e3381848b843ca9813acdd0762a3b3e4711a90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this code was assuming that all cquery target patterns should
use the root repository's .bazelignore contents which was incorrect.
Because the way this manifested itself was that when cquery drives
populating the graph and when it queries it, it would use different
keys, this led to misleading messages about packages not being in scope.