SpawnLogModule: rename exec log w. ext #22172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `execution.log` to `execution.binpb.zstd` to better reflect the file type that Build Event service should expect to handle.
sluongng
force-pushed
the
sluongng/exec-log-extension
branch
from
91a5dcb
to
eaf1516
Compare
|
cc: @tjgq |
github-actions
bot
added
the
awaiting-review
tjgq
approved these changes
Apr 30, 2024
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
sluongng
added a commit
to buildbuddy-io/buildbuddy
that referenced
this pull request
Apr 30, 2024
Let users download the compact execution log with the correct file extension. This way users could immediately tell how to consume the downloaded file. Also support the new file name that was proposed in (1). (1): bazelbuild/bazel#22172
sluongng
added a commit
to buildbuddy-io/buildbuddy
that referenced
this pull request
Apr 30, 2024
Let users download the compact execution log with the correct file extension. This way users could immediately tell how to consume the downloaded file. Also support the new file name that was proposed in (1). (1): bazelbuild/bazel#22172
|
@bazel-io fork 7.2.0 |
bazel-io
removed
the
potential release blocker
iancha1992
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Apr 30, 2024
Closes bazelbuild#22172. PiperOrigin-RevId: 629494462 Change-Id: Ib1febd4244c2a919969c125a96512d13cf6d6a6b
iancha1992
added
the
team-Remote-Exec
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
Closes bazelbuild#22172. PiperOrigin-RevId: 629494462 Change-Id: Ib1febd4244c2a919969c125a96512d13cf6d6a6b
|
The changes in this PR have been included in Bazel 7.2.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
execution.logtoexecution_log.binpb.zstdto better reflect thefile type that Build Event service should expect to handle.