[WIP] Add tests for more types of flag merging. #22386
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flag merging is used in platform mappings, and the in progress platform-based flags. Issues: - Implicit options are droppped - Repeating native and Starlark flags overwrite previous values instead of appending. Work towards platform-based flags: bazelbuild#19409. PiperOrigin-RevId: 634039493 Change-Id: I65006ed00bef94e7f944afc447315c6e9504b50b
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag merging is used in platform mappings, and the in progress platform-based flags.
Issues:
Work towards platform-based flags: #19409.
PiperOrigin-RevId: 634039493
Change-Id: I65006ed00bef94e7f944afc447315c6e9504b50b