Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up build after update to 7.2.0 #22400

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented May 16, 2024

No description provided.

@fmeum fmeum force-pushed the bazel-7.2.0 branch 3 times, most recently from e191001 to bf97b89 Compare May 16, 2024 12:44
@fmeum
Copy link
Collaborator Author

fmeum commented May 16, 2024

@keertk @iancha1992 FYI, I prepared this PR to verify compatibility with the new lockfile format. Happy to finalize it when 7.2.0 lands.

@iancha1992
Copy link
Member

@keertk @iancha1992 FYI, I prepared this PR to verify compatibility with the new lockfile format. Happy to finalize it when 7.2.0 lands.

Just FYI, if you change the .bazelversion, I think you might need to update the lockfile on all four platforms.

@fmeum
Copy link
Collaborator Author

fmeum commented May 16, 2024

Thanks, I'm in the process of setting up a Windows VM for that. But I likely need to do it again after the actual release, so I'll wait for that.

@Wyverald
Copy link
Member

Thanks, I'm in the process of setting up a Windows VM for that. But I likely need to do it again after the actual release, so I'll wait for that.

I'd suggest you not to worry about it, and let us (me?) do the work when 7.2.0 is actually released :) I've done this multiple times now and have all four machine types on hand.

@Wyverald
Copy link
Member

or, actually, if we could get rules_python to declare certain module extensions of theirs to be reproducible, we might be able to just remove all traces of them from the lockfile.

@fmeum
Copy link
Collaborator Author

fmeum commented May 16, 2024

or, actually, if we could get rules_python to declare certain module extensions of theirs to be reproducible, we might be able to just remove all traces of them from the lockfile.

I looked into that today: Two of their extensions are trivially reproducible (bazelbuild/rules_python#1892), but the pip extension is both os/arch dependendent and not reproducible: it talks to https://pypi.org/simple/ (don't click on that link, it might freeze your browser) during extension evaluation.

@fmeum fmeum force-pushed the bazel-7.2.0 branch 3 times, most recently from 724a3df to 261aba9 Compare May 29, 2024 22:30
@fmeum fmeum changed the title Build Bazel with Bazel 7.2.0rc1 Build Bazel with Bazel 7.2.0 Jun 11, 2024
@fmeum fmeum changed the title Build Bazel with Bazel 7.2.0 Remove unnecessary build code after update to 7.2.0 Jun 11, 2024
@fmeum fmeum changed the title Remove unnecessary build code after update to 7.2.0 Clean up build after update to 7.2.0 Jun 11, 2024
@fmeum fmeum marked this pull request as ready for review June 11, 2024 16:03
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Jun 11, 2024
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jun 11, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Jun 11, 2024

@bazel-io fork 7.3.0

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jun 12, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jun 12, 2024
Closes bazelbuild#22400.

PiperOrigin-RevId: 642564375
Change-Id: I1326aa33ddd30d29a51b928adcea0def42304fe9
@fmeum fmeum deleted the bazel-7.2.0 branch June 12, 2024 10:41
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jun 12, 2024
Closes bazelbuild#22400.

PiperOrigin-RevId: 642564375
Change-Id: I1326aa33ddd30d29a51b928adcea0def42304fe9
github-merge-queue bot pushed a commit that referenced this pull request Jun 12, 2024
Closes #22400.

PiperOrigin-RevId: 642564375
Change-Id: I1326aa33ddd30d29a51b928adcea0def42304fe9

Commit
2758f55

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants