Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.2.0] Update @rules_java v7.6.1 #22480

Merged
merged 4 commits into from
May 22, 2024
Merged

[7.2.0] Update @rules_java v7.6.1 #22480

merged 4 commits into from
May 22, 2024

Conversation

Wyverald
Copy link
Member

No description provided.

Wyverald and others added 2 commits May 21, 2024 17:14
Closes #22430.

Co-authored-by: hvd <hvadehra@gmail.com>
PiperOrigin-RevId: 635920357
Change-Id: I2ce7155ddb8d544f40a1940a1b44dfee8d2af5a7
@Wyverald Wyverald requested a review from a team as a code owner May 21, 2024 21:23
Copy link

google-cla bot commented May 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label May 21, 2024
@iancha1992 iancha1992 added the team-Rules-Java Issues for Java rules label May 21, 2024
@iancha1992 iancha1992 enabled auto-merge May 21, 2024 21:30
@Wyverald
Copy link
Member Author

@hvadehra there's a crapton of these failures on CI:

com.google.devtools.build.lib.skyframe.BzlLoadFunction$BzlLoadFunctionException: com.google.devtools.build.lib.skyframe.BzlLoadFunction$BzlLoadFailedException: Label '@@rules_java~//java/common:java_common.bzl' is invalid because 'java/common' is not a package; perhaps you meant to put the colon here: '@@rules_java~//java:common/java_common.bzl'?
	at com.google.devtools.build.lib.skyframe.BzlLoadFunction.compute(BzlLoadFunction.java:199)
	at com.google.devtools.build.skyframe.AbstractParallelEvaluator$Evaluate.run(AbstractParallelEvaluator.java:461)
	at com.google.devtools.build.lib.concurrent.AbstractQueueVisitor$WrappedRunnable.run(AbstractQueueVisitor.java:414)
	at java.base/java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1403)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)
Caused by: com.google.devtools.build.lib.skyframe.BzlLoadFunction$BzlLoadFailedException: Label '@@rules_java~//java/common:java_common.bzl' is invalid because 'java/common' is not a package; perhaps you meant to put the colon here: '@@rules_java~//java:common/java_common.bzl'?
	at com.google.devtools.build.lib.skyframe.BzlLoadFunction$BzlLoadFailedException.labelCrossesPackageBoundary(BzlLoadFunction.java:1660)
	at com.google.devtools.build.lib.skyframe.BzlLoadFunction.validatePackageAndGetCompileKey(BzlLoadFunction.java:691)
	at com.google.devtools.build.lib.skyframe.BzlLoadFunction.computeInternal(BzlLoadFunction.java:545)
	at com.google.devtools.build.lib.skyframe.BzlLoadFunction.compute(BzlLoadFunction.java:197)
	... 8 more

Did I miss something during the cherry-pick? The PR was fine on master.

@hvadehra
Copy link
Member

I think it's just the unit tests setup. Likely we just need 999762d and just the test setup bits from 20c49b4

PiperOrigin-RevId: 623470267
Change-Id: I203929d7a3f8626aba71c6f1af7d1df82096b37e
BEGIN_PUBLIC

Add `load()` statements for the Bazel builtin top-level java symbols

Loads are being added in preparation for moving the symbols out of Bazel and into `rules_java`.

END_PUBLIC

PiperOrigin-RevId: 624087139
Change-Id: I3d98ec19cf1c2cd7e587e4a3e6117c49d7ffd2e8
@iancha1992 iancha1992 added this pull request to the merge queue May 22, 2024
Merged via the queue into release-7.2.0 with commit 84525a0 May 22, 2024
34 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label May 22, 2024
@Wyverald Wyverald deleted the wyv-720-rj branch May 22, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants