Fail early on certain invalid labels in module files #22487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
The following validation checks were not enforced due to backwards compatibility concerns, but ended up crashing Bazel when invalid labels made it into the lockfile, which is enabled by default. We might as well enable them now: * Fail if a label passed to `use_extension` is not valid * Fail if a label passed to the `patches` attribute of an override is not valid or points to a repo other than the main repo
fmeum
force-pushed
the
21845-invalid-labels
branch
from
abb5442
to
f5e6e6c
Compare
meteorcloudy
approved these changes
May 22, 2024
|
@bazel-io fork 7.2.0 |
meteorcloudy
added
awaiting-PR-merge
Wyverald
approved these changes
May 22, 2024
| // Preserve backwards compatibility by not failing eagerly, rather keep the invalid label and | ||
| // let the extension fail when evaluated. | ||
| return rawExtensionBzlFile; | ||
| } catch (LabelSyntaxException e) { |
There was a problem hiding this comment.
just an observation: this is not the part we need to fix, right? The bug we're trying to fix is labels with invalid apparent repo names. This fix in particular only affects when the failure happens (either eagerly at module file eval time, or somewhat more lazily at DepGraphFunction time).
There was a problem hiding this comment.
(still nice to have the fix, though)
There was a problem hiding this comment.
Yes, this was just something else related to label validation that we postponed due to backwards compatibility concerns and now might as well do.
github-actions
bot
removed
the
awaiting-PR-merge
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
May 22, 2024
The following validation checks were not enforced due to backwards compatibility concerns, but ended up crashing Bazel when invalid labels made it into the lockfile, which is enabled by default. We might as well enable them now: * Fail if a label passed to `use_extension` is not valid * Fail if a label passed to the `patches` attribute of an override is not valid or points to a repo other than the main repo Work towards bazelbuild#21845 Closes bazelbuild#22487. PiperOrigin-RevId: 636255834 Change-Id: I55dda374cd1716e514c4d78642479b136fd3ad43
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 22, 2024
The following validation checks were not enforced due to backwards compatibility concerns, but ended up crashing Bazel when invalid labels made it into the lockfile, which is enabled by default. We might as well enable them now: * Fail if a label passed to `use_extension` is not valid * Fail if a label passed to the `patches` attribute of an override is not valid or points to a repo other than the main repo Work towards #21845 Closes #22487. PiperOrigin-RevId: 636255834 Change-Id: I55dda374cd1716e514c4d78642479b136fd3ad43 Commit cdace8f Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following validation checks were not enforced due to backwards compatibility concerns, but ended up crashing Bazel when invalid labels made it into the lockfile, which is enabled by default. We might as well enable them now:
use_extensionis not validpatchesattribute of an override is not valid or points to a repo other than the main repoWork towards #21845