Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.2.0] Add support for overlays in source.json #22525

Merged
merged 1 commit into from
May 23, 2024

Conversation

bazel-io
Copy link
Member

This is a continuation of #22155 that adds the newly added 'remote_files' attribute for http_archive to the bzlmod functionality.

The end goal is to then update BCR to this new functionality to overlay files rather than use patch files when providing MODULE/WORKSPACE/BUILD files.

bazelbuild/bazel-central-registry#1566 has a good discussion of the rationale.

Co-authored-by: Fabian Meumertzheim fabian@meumertzhe.im

Closes #22349.

PiperOrigin-RevId: 636682112
Change-Id: Ief070985598a7c0f427a98cd3daeb69a0984f7be

Commit c4167e3

This is a continuation of bazelbuild#22155 that adds the newly added 'remote_files' attribute for http_archive to the bzlmod functionality.

The end goal is to then update BCR to this new functionality to overlay files rather than use patch files when providing MODULE/WORKSPACE/BUILD files.

bazelbuild/bazel-central-registry#1566 has a good discussion of the rationale.

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>

Closes bazelbuild#22349.

PiperOrigin-RevId: 636682112
Change-Id: Ief070985598a7c0f427a98cd3daeb69a0984f7be
@bazel-io bazel-io added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label May 23, 2024
@bazel-io bazel-io requested a review from a team as a code owner May 23, 2024 21:47
@bazel-io bazel-io added the awaiting-review PR is awaiting review from an assigned reviewer label May 23, 2024
@bazel-io bazel-io requested review from fmeum and Wyverald May 23, 2024 21:47
@iancha1992 iancha1992 removed the request for review from fmeum May 23, 2024 22:24
@iancha1992 iancha1992 enabled auto-merge May 23, 2024 22:24
@iancha1992 iancha1992 added this pull request to the merge queue May 23, 2024
Merged via the queue into bazelbuild:release-7.2.0 with commit bfa9c6a May 23, 2024
33 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants