Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(singlejar): Add Log4j plugins cache combiner #22581

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

stevebarrau
Copy link
Contributor

@stevebarrau stevebarrau commented May 29, 2024

In singlejar, add support for combining Log4j2 plugins cache file.

Log4j2 plugins are Java annotations collected by a compiler plugin into .dat files for Log4j2 runtime to find them fast. With correct dependency on a java_plugin, Bazel already runs the java plugin compiler correctly. The behavior is correct on bazel run JAR, but not on _deploy.jar fat jars.

The silent clobbering of files in general, and the example of these Log4j2 .dat files in particular, is discussed in #7330.

I tested this fix in my project using Bazel 7.0.2, compiling //src:java_tools_prebuilt.zip, and overriding @remote_java_tools_darwin_arm64 and @remote_java_tools_linux.

@stevebarrau stevebarrau changed the title feat(singlejar): Add Log4j2Plugins combiner feat(singlejar): Add Log4j plugins cache combiner May 29, 2024
@github-actions github-actions bot added team-Rules-Java Issues for Java rules awaiting-review PR is awaiting review from an assigned reviewer labels May 29, 2024
@sgowroji sgowroji added awaiting-user-response Awaiting a response from the author and removed awaiting-review PR is awaiting review from an assigned reviewer labels May 29, 2024
@stevebarrau
Copy link
Contributor Author

@sgowroji what question do I need to answer for "awaiting-user-response" to get removed?

@softprops @jwilliams-ocient from #7330; does this help the issue for you?

@sgowroji
Copy link
Member

@stevebarrau Could you please take a look at the failing checks?

@stevebarrau stevebarrau force-pushed the singlejar-add-log4j-plugin-cache-combiner branch from 659623f to d8130cb Compare May 30, 2024 09:06
@stevebarrau
Copy link
Contributor Author

@sgowroji PTAL.

@sgowroji sgowroji added awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-user-response Awaiting a response from the author labels May 30, 2024
@hvadehra
Copy link
Member

cc @cushon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Rules-Java Issues for Java rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants