Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo fix for ASSEMBLER_WITH_C_PREPROCESSOR #22591

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Typo fix for ASSEMBLER_WITH_C_PREPROCESSOR #22591

wants to merge 1 commit into from

Conversation

werkt
Copy link
Contributor

@werkt werkt commented May 30, 2024

No description provided.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label May 30, 2024
@sgowroji sgowroji added team-Rules-CPP Issues for C++ rules team-Documentation Documentation improvements that cannot be directly linked to other team labels labels May 31, 2024
@keertk keertk requested a review from meteorcloudy June 5, 2024 06:00
pzembrod
pzembrod reviewed Jun 5, 2024
View reviewed changes
src/main/starlark/builtins_bzl/common/cc/cc_helper.bzl
@@ -346,7 +346,7 @@ OBJCPP_SOURCE = [".mm"]
CLIF_INPUT_PROTO = [".ipb"]
CLIF_OUTPUT_PROTO = [".opb"]
CC_HEADER = [".h", ".hh", ".hpp", ".ipp", ".hxx", ".h++", ".inc", ".inl", ".tlh", ".tli", ".H", ".tcc"]
ASSESMBLER_WITH_C_PREPROCESSOR = [".S"]
ASSEMBLER_WITH_C_PREPROCESSOR = [".S"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a Google-internal reference to this symbol in Piper that needs to be updated after the next blaze release.
Could you please keep the old name as a duplicate here, along with the new name, and add this comment for me to track the cleanup?
TODO(b/345158656): Remove ASSESMBLER_WITH_C_PREPROCESSOR after next blaze release

@comius comius added awaiting-user-response Awaiting a response from the author and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzembrod pzembrod pzembrod left review comments

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
awaiting-user-response Awaiting a response from the author team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@werkt @meteorcloudy @pzembrod @comius @sgowroji