Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bzl-style.md #22733

Closed
wants to merge 1 commit into from
Closed

Update bzl-style.md #22733

wants to merge 1 commit into from

Conversation

RajWorking
Copy link

Conventionally, name should be the first argument when defining a macro.

Conventionally, `name` should be the first argument when defining a macro.
Copy link

google-cla bot commented Jun 13, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-review PR is awaiting review from an assigned reviewer labels Jun 13, 2024
@keertk
Copy link
Member

keertk commented Jun 13, 2024

Hi @RajWorking thanks for the PR! Could you sign the CLA please?

@keertk keertk requested a review from meteorcloudy June 13, 2024 15:35
@iancha1992 iancha1992 added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 17, 2024
@RajWorking RajWorking closed this Jun 19, 2024
@RajWorking RajWorking deleted the patch-1 branch June 19, 2024 04:05
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants