Do not fail a sandboxed spawn for missing execution statistics #22780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already the case for "local" spawns. Statistics may be missing if the spawn wrapper exits abnormally.
|
@bazel-io fork 7.3.0 |
|
@bazel-io fork 7.2.1 |
github-actions
bot
added
team-Performance
This was referenced Jun 18, 2024
|
I marked this for cherry-picking as users reported on Slack that this is blocking their Bazel 7 update and the fix is very safe. |
tjgq
requested changes
Jun 18, 2024
src/main/java/com/google/devtools/build/lib/shell/ExecutionStatistics.java
Outdated
Show resolved
Hide resolved
tjgq
added
awaiting-PR-merge
|
@tjgq Added a "Fixes" line to the PR description. |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jun 18, 2024
This was already the case for "local" spawns. Statistics may be missing if the spawn wrapper exits abnormally. Fixes bazelbuild#22151. Closes bazelbuild#22780. PiperOrigin-RevId: 644378541 Change-Id: Ia3d792f380b78945523f21875c593744b60f0c81
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jun 18, 2024
This was already the case for "local" spawns. Statistics may be missing if the spawn wrapper exits abnormally. Fixes bazelbuild#22151. Closes bazelbuild#22780. PiperOrigin-RevId: 644378541 Change-Id: Ia3d792f380b78945523f21875c593744b60f0c81
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
#22790) This was already the case for "local" spawns. Statistics may be missing if the spawn wrapper exits abnormally. Fixes #22151. Closes #22780. PiperOrigin-RevId: 644378541 Change-Id: Ia3d792f380b78945523f21875c593744b60f0c81 Commit ec41dd1 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
#22791) This was already the case for "local" spawns. Statistics may be missing if the spawn wrapper exits abnormally. Fixes #22151. Closes #22780. PiperOrigin-RevId: 644378541 Change-Id: Ia3d792f380b78945523f21875c593744b60f0c81 Commit ec41dd1 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already the case for "local" spawns. Statistics may be missing if the spawn wrapper exits abnormally.
Fixes #22151