[7.2.1] Enforce and await cleanup in StarlarkBaseExternalContext
#22814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`StarlarkBaseExternalContext` now implements `AutoCloseable` and, in `close()`: 1. Cancels all pending async tasks. 2. Awaits their termination. 3. Cleans up the working directory (always for module extensions, on failure for repo rules). 4. Fails if there were pending async tasks in an otherwise successful evaluation. Previously, module extensions didn't do any of those. Repo rules did 1 and 4 and sometimes 3, but not in all cases. This change required replacing the fixed-size thread pool in `DownloadManager` with virtual threads, thereby resolving a TODO about not using a fixed-size thread pool for the `GrpcRemoteDownloader`. Work towards bazelbuild#22680 Work towards bazelbuild#22748 Closes bazelbuild#22772. PiperOrigin-RevId: 644669599 Change-Id: Ib71e5bf346830b92277ac2bd473e11c834cb2624
github-actions
bot
added
awaiting-review
meteorcloudy
approved these changes
Jun 20, 2024
|
Hmm, not sure why this is failing: |
fmeum
changed the title
StarlarkBaseExternalContextStarlarkBaseExternalContext
|
@meteorcloudy Could you trigger a rerun? It does pass locally for me. |
|
I already did, but it didn't seem to help. Maybe RBE has some weird java toolchain setup? |
|
/cc @hvadehra in case you know something about this. |
auto-merge was automatically disabled
June 20, 2024 12:34
Head branch was pushed to by a user without write access
|
(I should have clarified the fix from back then is apparently already in 7.x thanks to 4362d97, but bumping it further could work. If it doesn't, I can take a stab at debugging) |
|
I also don't mind disabling this test on RBE since we already have it covered on other platforms. |
hvadehra
reviewed
Jun 20, 2024
| @@ -72,7 +72,7 @@ function test_jdeps() { | |||
| # src/test/shell/bazel/jdeps_class_denylist.txt. | |||
| find . -type f -iname \*class | \ | |||
| grep -vFf "$denylist" | \ | |||
There was a problem hiding this comment.
adding a sort -r after this should workaround the problem (for now). I'll look into a principled fix later.
auto-merge was automatically disabled
June 20, 2024 16:31
Head branch was pushed to by a user without write access
Merged
via the queue into
bazelbuild:release-7.2.1
with commit Jun 20, 2024
8fb4dce
32 checks passed
github-actions
bot
removed
the
awaiting-review
keertk
added a commit
to bazel-io/bazel
that referenced
this pull request
Jun 20, 2024
[7.2.1] Enforce and await cleanup in `StarlarkBaseExternalContext` (bazelbuild#22814)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StarlarkBaseExternalContextnow implementsAutoCloseableand, inclose():Previously, module extensions didn't do any of those. Repo rules did 1 and 4 and sometimes 3, but not in all cases.
This change required replacing the fixed-size thread pool in
DownloadManagerwith virtual threads, thereby resolving a TODO about not using a fixed-size thread pool for theGrpcRemoteDownloader.Work towards #22680
Work towards #22748
Closes #22772
PiperOrigin-RevId: 644669599
Change-Id: Ib71e5bf346830b92277ac2bd473e11c834cb2624
Closes #22775