Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.3.0] Push makeExecutable down into AbstractFileWriteAction subclasses #22845

Merged
merged 1 commit into from
Jun 21, 2024
Merged

[7.3.0] Push makeExecutable down into AbstractFileWriteAction subclasses #22845

merged 1 commit into from
Jun 21, 2024

Commits on Jun 21, 2024

  1. Push makeExecutable down into AbstractFileWriteAction subclasses 

    Getting rid of the single boolean field on `AbstractFileWriteAction` reduces padding on each subclass instance and in particular frees up a 4-byte field on `CppModuleMapAction`.

Also use a lambda to define `newDeterministicWriter` if possible for improved readability.

This prepares for future changes that will add fields to `CppModuleMapAction` to support path mapping.

Work towards bazelbuild#6526

Closes bazelbuild#22609.

PiperOrigin-RevId: 643340715
Change-Id: Id3af26049098e6dfa731f0e7a1be6709bea0d9f2
    @fmeum
    fmeum committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    8f05680 View commit details
    Browse the repository at this point in the history