Bump python-gflags to 3.1.0, take two.

[spxtr]

c/8250 caused a breakage on windows. I don't have a windows machine to test this on, so I'll have to lean on Jenkins. Also, changing to GitHub because I am way more familiar with this interface than with Gerrit.

[spxtr]

@damienmg PTAL. I still see lots of failures from android tests, but I'm not sure that those are related to this PR. The windows test that failed to build before is now passing, I think. It's hard to tell what with all the java/android failures.

[damienmg]

Ok the failure seems genuine, added the android support experts to look at it and advise.

[aj-michael]

The problem is in the jenkins log:

no such package '@bazel_tools//third_party/py/six': BUILD file not found on package path and referenced by '@bazel_tools//third_party/py/gflags:gflags'

We bundle gflags with bazel into the @bazel_tools repository, but we do not currently do that for six. This CL adds a dep from gflags to six, so we need to bundle six as well. You need to update //src:embedded_tools to have a dep on //third_party/py/six:srcs.

[damienmg]

Humm this has to be done as a separate PR because 3rd party and non 3rd party code are like 2 repository for us.

[spxtr]

retest this please

[damienmg]

Test failure does looks unrelated, good to merge tomorrow, hopefully we do not encounter any more hurdle inside Google.

[spxtr]

Thanks :)

[spxtr]

@damienmg any update?

[damienmg]

Sorry I have been fighting fire the whole week, did not got around to import it yet.

…

On Thu, Jul 27, 2017 at 11:14 PM Joe Finney ***@***.***> wrote: @damienmg <https://github.com/damienmg> any update? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3363 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADjHf_wkQk_MHIGFzYqMMx2z0B6A81yoks5sSP3LgaJpZM4OUxmt> .

[spxtr]

No worries.

[damienmg]

Sorry I haven't got time to deal with it, trying to finish things before going on holidays. Reassigning to @aj-michael. I know they are some concern about version mistchmatch between the version of gflags in google and gflags 3, but so far it is not a problem.

[dslomov]

retest this please

[dslomov]

CI looks good

[aj-michael]

Sorry for the delay, I just realized this was assigned to me and I do not have much time this week.

This change looks fine for Bazel, however, internally we still use the older gflags and I suspect it will not be easy to migrate. I am not sure what the teams thoughts are on trying to keep Bazel compatible with both versions, especially since I suspect the reason to update it in Bazel is to use new features, which will then break internal Bazel.

[spxtr]

The reason for using it in Bazel is actually just that the newer version supports python 3. It's not really for any new features.

[dslomov]

I'll merge this