-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add empty WORKSPACE file to example workspace #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lberki
added a commit
that referenced
this pull request
Jun 25, 2014
Add empty WORKSPACE file to example workspace
Closed
bazel-io
pushed a commit
that referenced
this pull request
Dec 20, 2017
Change-Id: Ie8dd0aa0ed6234fc3fd2e337fd50f9f7d5c7d2c1 PiperOrigin-RevId: 179607524
tomaszstrejczek
pushed a commit
to tomaszstrejczek/bazel
that referenced
this pull request
Oct 20, 2019
Add csharp_configure rule
comius
added a commit
to comius/bazel
that referenced
this pull request
Nov 27, 2020
meteorcloudy
pushed a commit
to meteorcloudy/bazel
that referenced
this pull request
Apr 21, 2021
Index registry impl
gregestren
added a commit
to gregestren/bazel
that referenced
this pull request
Nov 23, 2021
This implements approach bazelbuild#4 of bazelbuild#13047 (comment). The basic change adds a new toolchain resolution mode: "resolve iff the target has a select()". It then sets alias() to that mode. We could remove this special casing if we ever ubiquitously provide platfrom info to *all* rules (bazelbuild#12899 (comment)). RELNOTES: alias() can now select() directly on constraint_value() Fixes bazelbuild#13047. PiperOrigin-RevId: 411684872 Change-Id: I998ef9bba3226871651fc14bd9ed268e9a3de82c
bazel-io
pushed a commit
that referenced
this pull request
Nov 23, 2021
This implements approach #4 of #13047 (comment). The basic change adds a new toolchain resolution mode: "resolve iff the target has a select()". It then sets alias() to that mode. We could remove this special casing if we ever ubiquitously provide platform info to *all* rules (#12899 (comment)). RELNOTES: alias() can now select() directly on constraint_value() Fixes #13047. Closes #14310. PiperOrigin-RevId: 411868223
Bencodes
pushed a commit
to Bencodes/bazel
that referenced
this pull request
Jan 10, 2022
This implements approach bazelbuild#4 of bazelbuild#13047 (comment). The basic change adds a new toolchain resolution mode: "resolve iff the target has a select()". It then sets alias() to that mode. We could remove this special casing if we ever ubiquitously provide platform info to *all* rules (bazelbuild#12899 (comment)). RELNOTES: alias() can now select() directly on constraint_value() Fixes bazelbuild#13047. Closes bazelbuild#14310. PiperOrigin-RevId: 411868223
brentleyjones
pushed a commit
to brentleyjones/bazel
that referenced
this pull request
Feb 8, 2022
This implements approach bazelbuild#4 of bazelbuild#13047 (comment). The basic change adds a new toolchain resolution mode: "resolve iff the target has a select()". It then sets alias() to that mode. We could remove this special casing if we ever ubiquitously provide platform info to *all* rules (bazelbuild#12899 (comment)). RELNOTES: alias() can now select() directly on constraint_value() Fixes bazelbuild#13047. Closes bazelbuild#14310. PiperOrigin-RevId: 411868223 (cherry picked from commit 1c3a245)
Wyverald
pushed a commit
that referenced
this pull request
Feb 9, 2022
This implements approach #4 of #13047 (comment). The basic change adds a new toolchain resolution mode: "resolve iff the target has a select()". It then sets alias() to that mode. We could remove this special casing if we ever ubiquitously provide platform info to *all* rules (#12899 (comment)). RELNOTES: alias() can now select() directly on constraint_value() Fixes #13047. Closes #14310. PiperOrigin-RevId: 411868223 (cherry picked from commit 1c3a245) Co-authored-by: Greg Estren <gregestren@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be needed once Bazel is looking for the build root via WORKSPACE file.
Mentioning @lberki in the hope Github will send you a notification.