Set Locale to English when uppercasing strings to match Enums #5184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5157
If a user's default system locale is not
en
,en_US
oren_UK
, there may be a chance thatString#toUpperCase
will result in a string that does not exist in the Enum declaration. This is the case in #5157.To fix this, it's either
toUpperCase
calls orBazel.java
.I chose the first because it seemed less intrusive, but I'm open to suggestions.