Importing remote-apis repository into Bazel for Remote API v2. #5605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ola-rozenfeld
force-pushed
the
remoteapis
branch
from
b8a8206
to
08cdef6
Compare
|
Please fix the test. |
ola-rozenfeld
force-pushed
the
remoteapis
branch
from
08cdef6
to
a1b861b
Compare
|
Yes, the PR is now merged, and this file is identical. Right, I forgot to amend third_party/BUILD. A sec, will update. |
ola-rozenfeld
force-pushed
the
remoteapis
branch
4 times, most recently
from
aa65f80
to
1385e9c
Compare
ola-rozenfeld
force-pushed
the
remoteapis
branch
2 times, most recently
from
5dce65a
to
f169b3c
Compare
|
Tests now passed, PTAL! |
buchgr
approved these changes
Aug 7, 2018
|
Thank you! Done (I think). Note I don't have merging permissions. |
|
still not seeing an updated commit message. Your current commit message is which looks like a |
Change-Id: I245c8514adedfa443e3ffd41a54714f40fc193c4
ola-rozenfeld
force-pushed
the
remoteapis
branch
from
f169b3c
to
88b31f9
Compare
|
How about now? |
|
Looks good. I ll import after the testing completes. |
iirina
pushed a commit
that referenced
this pull request
Aug 13, 2018
Import the current version of https://github.com/bazelbuild/remote-apis/ into Bazel to enable Remote API V2 migration. Change-Id: I245c8514adedfa443e3ffd41a54714f40fc193c4 Closes #5605. Change-Id: I245c8514adedfa443e3ffd41a54714f40fc193c4 PiperOrigin-RevId: 208236825
iirina
pushed a commit
that referenced
this pull request
Aug 13, 2018
Import the current version of https://github.com/bazelbuild/remote-apis/ into Bazel to enable Remote API V2 migration. Change-Id: I245c8514adedfa443e3ffd41a54714f40fc193c4 Closes #5605. Change-Id: I245c8514adedfa443e3ffd41a54714f40fc193c4 PiperOrigin-RevId: 208236825
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import the current version of https://github.com/bazelbuild/remote-apis/ into Bazel to enable Remote API V2 migration.
Change-Id: I245c8514adedfa443e3ffd41a54714f40fc193c4