Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip optional maven dependencies in generate_workspace. #627

Closed
wants to merge 1 commit into from

Conversation

wjywbs
Copy link
Contributor

@wjywbs wjywbs commented Nov 19, 2015

No description provided.

@damienmg
Copy link
Contributor

@kchodorow can you take care of this one?

@kchodorow
Copy link
Contributor

Thanks for the pull request, looks good! Could you please sign the CLA at https://cla.developers.google.com so we can merge in your change? (Generally you'd be automatically prompted, but for some reason our CLA-signing webhook is erroring out on this pull request.)

@wjywbs
Copy link
Contributor Author

wjywbs commented Nov 19, 2015

I added my username in the "GitHub Account Name" of my signed CLA (previously for Chromium).

@kchodorow
Copy link
Contributor

Got it, thanks! Importing...

@damienmg
Copy link
Contributor

We should update the list of contributors...

On Thu, Nov 19, 2015 at 5:44 PM Kristina notifications@github.com wrote:

Got it, thanks! Importing...


Reply to this email directly or view it on GitHub
#627 (comment).

damienmg pushed a commit that referenced this pull request Nov 20, 2015
--
Reviewed-on: #627
MOS_MIGRATED_REVID=108252420
@damienmg
Copy link
Contributor

Merged, thank you!

@damienmg damienmg closed this Nov 20, 2015
@wjywbs wjywbs deleted the optional branch November 24, 2015 05:31
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this pull request Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants