Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows, test-wrapper: write undeclared outputs mf #6640

Closed

Conversation

laszlocsomor
Copy link
Contributor

@laszlocsomor laszlocsomor commented Nov 9, 2018

In this commit:

  • implement logic to write the undeclared outputs
    manifest

  • fix the name of directory entries in the zip
    file: now they end with "/" to be compatible
    with zip files created by "/usr/bin/zip"

See: #5508

In this commit:

- implement logic to write the undeclared outputs
  manifest

- fix the name of directory entries in the zip
  file: now they end with "/" to be compatible
  with zip files created by "/usr/bin/zip"

See: bazelbuild#5508

Change-Id: I7606114ad3e82da662bece63997d03d1d9c2fc8e
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bazel-io bazel-io closed this in d34d32f Nov 9, 2018
@laszlocsomor laszlocsomor deleted the test-wrapper-wip-3 branch November 12, 2018 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants