Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth support for proxy downloads #759

Closed
wants to merge 2 commits into from

Conversation

kchodorow
Copy link
Contributor

Should fix #587.

RELNOTES: Support for downloading remote resources through proxies by setting HTTP_PROXY (or HTTPS_PROXY).

Change-Id: If701d081d5cac4cc87634c4e3ddd11e8d74cb33e
@kchodorow
Copy link
Contributor Author

Shouldn't no password be a valid case?

I couldn't find documentation about it. Does Java need to even know about the username if the password isn't set?

@damienmg
Copy link
Contributor

damienmg commented Jan 7, 2016

I have no idea. Well I guess it does not hurt to throw an error there.

On Thu, Jan 7, 2016 at 10:23 PM Kristina notifications@github.com wrote:

Shouldn't no password be a valid case?

I couldn't find documentation about it. Does Java need to even know about
the username if the password isn't set?


Reply to this email directly or view it on GitHub
#759 (comment).

Change-Id: I4ae18c4f1a9e911e538efd446323e279e9776eec
@damienmg
Copy link
Contributor

damienmg commented Jan 7, 2016

LGTM. Should I import it or will you do it?

@kchodorow
Copy link
Contributor Author

Thanks, I'll do it.

bazel-io pushed a commit that referenced this pull request Jan 11, 2016
Should fix #587.

RELNOTES: Support for downloading remote resources through proxies by setting HTTP_PROXY (or HTTPS_PROXY).

--
Change-Id: I4ae18c4f1a9e911e538efd446323e279e9776eec
Reviewed-on: #759
MOS_MIGRATED_REVID=111708438
@damienmg
Copy link
Contributor

Was imported

@damienmg damienmg closed this Jan 12, 2016
@plattenschieber
Copy link

plattenschieber commented Aug 9, 2017

No password is indeed a valid case. I'm using it everywhere (apt-get, git, ...). I am helping myself out here with a username:123 setting.

@mcelhennyi
Copy link

Does bazel support auth? I cant seem to get my auth required prox-ied computer to work, but my non auth prox-ied VM works?

luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this pull request Sep 5, 2022
    Should fix #587.

    RELNOTES: Support for downloading remote resources through proxies by setting HTTP_PROXY (or HTTPS_PROXY).

    --
    Change-Id: I4ae18c4f1a9e911e538efd446323e279e9776eec
    Reviewed-on: bazelbuild/bazel#759
    MOS_MIGRATED_REVID=111708438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tensorflow building issue on ubuntu 14.04: Accessing remote repository through a proxy
4 participants