Windows: add --incompatible_windows_native_test_wrapper #7644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the --incompatible_windows_native_test_wrapper flag (default: false). This flag has no effect on platforms other than Windows. When using `bazel test`, Bazel does not execute tests directly. Instead Bazel runs a "test wrapper" as a subprocess, which sets up the environment for the test and runs the test. By default, Bazel uses a Bash script (`@bazel_tools//tools/test:test-setup.sh`) as the test wrapper, on all platforms. The new flag allows using an alternative test wrapper written in C++ that does not depend on Bash. Flag semantics: - When true: Bazel uses the C++ test wrapper from `@bazel_tools//tools/test:tw`. This test wrapper does not depend on Bash. - When false: Bazel uses the Bash script test wrapper also used on every other platform, from `@bazel_tools//tools/test:test-setup.sh`. This script requires Bash. Incompatible flag: bazelbuild#6622 Related: bazelbuild#5508 RELNOTES[NEW]: Added --incompatible_windows_native_test_wrapper flag: enables using the Bash-less test wrapper on Windows. (No-op on other platforms.)
meteorcloudy
approved these changes
Mar 6, 2019
laszlocsomor
added a commit
that referenced
this pull request
Mar 7, 2019
Add the --incompatible_windows_native_test_wrapper flag (default: false). This flag has no effect on platforms other than Windows. When using `bazel test`, Bazel does not execute tests directly. Instead Bazel runs a "test wrapper" as a subprocess, which sets up the environment for the test and runs the test. By default, Bazel uses a Bash script (`@bazel_tools//tools/test:test-setup.sh`) as the test wrapper, on all platforms. The new flag allows using an alternative test wrapper written in C++ that does not depend on Bash. Flag semantics: - When true: Bazel uses the C++ test wrapper from `@bazel_tools//tools/test:tw`. This test wrapper does not depend on Bash. - When false: Bazel uses the Bash script test wrapper also used on every other platform, from `@bazel_tools//tools/test:test-setup.sh`. This script requires Bash. Incompatible flag: #6622 Related: #5508 RELNOTES[NEW]: Added --incompatible_windows_native_test_wrapper flag: enables using the Bash-less test wrapper on Windows. (No-op on other platforms.) Closes #7644. PiperOrigin-RevId: 237201616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the --incompatible_windows_native_test_wrapper
flag (default: false). This flag has no effect on
platforms other than Windows.
When using
bazel test, Bazel does not executetests directly. Instead Bazel runs a "test
wrapper" as a subprocess, which sets up the
environment for the test and runs the test.
By default, Bazel uses a Bash script
(
@bazel_tools//tools/test:test-setup.sh) as thetest wrapper, on all platforms. The new flag
allows using an alternative test wrapper written
in C++ that does not depend on Bash.
Flag semantics:
@bazel_tools//tools/test:tw. This test wrapperdoes not depend on Bash.
wrapper also used on every other platform, from
@bazel_tools//tools/test:test-setup.sh. Thisscript requires Bash.
Incompatible flag: #6622
Related: #5508
RELNOTES[NEW]: Added --incompatible_windows_native_test_wrapper flag: enables using the Bash-less test wrapper on Windows. (No-op on other platforms.)