-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest using release tag when running generate_workspace #778
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
CLAs look good, thanks! |
0.1.3 should work, I don't think we should modify the doc... |
I don't think this is a change we'd want to merge, as this isn't actually generate_workspace-specific, running |
Maybe we could compile generate_workspace and include it in the @bazel_tools repository so people can actually do (that would avoid the version issue) |
NGL, I was on Bazel 0.1.2, the latest version available on Homebrew. But until Bazel reaches 1.0 or something, I think it's inherently risky to ask people to clone |
I'm new to bazel; I wouldn't have thought to check babel-discuss for an issue like this. (Instead, I went straight to IRC.) |
I think we should either put generate_workspace into @bazel_tools or remove it entirely from bazelbuild/bazel (put in in its own repo). |
Maybe merge this for now and then rewrite the doc when |
I commented on #776, IMO, unless somebody thinks they're going to resolve issue #662 really soon (like, in the next week or so), then we should mention the workaround in the documentation. |
As I said on the bug I would rather recommends to checkout the version corresponding to their binary rather that building bazel from head. |
Fixed. |
LGTM if it's ok with @kchodorow |
SGTM, I'll merge it in. |
This was merged |
Apropos issue #776. This hint in the doc would have saved me from filing a bogus bug. -- Reviewed-on: bazelbuild/bazel#778 MOS_MIGRATED_REVID=112972220
Apropos issue #776. This hint in the doc would have saved me from filing a bogus bug.