Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest using release tag when running generate_workspace #778

Closed
wants to merge 1 commit into from

Conversation

dfabulich
Copy link
Contributor

Apropos issue #776. This hint in the doc would have saved me from filing a bogus bug.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@dfabulich
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot
Copy link

CLAs look good, thanks!

@damienmg
Copy link
Contributor

0.1.3 should work, I don't think we should modify the doc...

@kchodorow
Copy link
Contributor

I don't think this is a change we'd want to merge, as this isn't actually generate_workspace-specific, running bazel build //src:bazel or even just bazel info with 0.1.2 should give you the same errors. As it's a temporary problem (version X isn't compatible with version Y), perhaps it would make more sense to send an announcement to bazel-discuss, instead of updating the docs.

@damienmg
Copy link
Contributor

Maybe we could compile generate_workspace and include it in the @bazel_tools repository so people can actually do bazel run @bazel_tools//:generate_workspace?

(that would avoid the version issue)

@dfabulich
Copy link
Contributor Author

NGL, I was on Bazel 0.1.2, the latest version available on Homebrew.

But until Bazel reaches 1.0 or something, I think it's inherently risky to ask people to clone master and expect that to work; it seems plausible that an issue like this may arise in the future, at least until issue #622 is resolved.

@dfabulich
Copy link
Contributor Author

I'm new to bazel; I wouldn't have thought to check babel-discuss for an issue like this. (Instead, I went straight to IRC.)

@kchodorow
Copy link
Contributor

I think we should either put generate_workspace into @bazel_tools or remove it entirely from bazelbuild/bazel (put in in its own repo).

@dfabulich
Copy link
Contributor Author

Maybe merge this for now and then rewrite the doc when generate_workspace has been moved to the right place, wherever that is?

@dfabulich
Copy link
Contributor Author

I commented on #776, generate_workspace doesn't even work when you use the latest bazel binary 0.1.3. It only works when you use ./compile.sh.

IMO, unless somebody thinks they're going to resolve issue #662 really soon (like, in the next week or so), then we should mention the workaround in the documentation.

@damienmg
Copy link
Contributor

As I said on the bug I would rather recommends to checkout the version corresponding to their binary rather that building bazel from head.

@dfabulich dfabulich changed the title Suggest building bazel from scratch to get the generate_workspace tool to work. Suggest using release tag when running generate_workspace Jan 13, 2016
@dfabulich
Copy link
Contributor Author

Fixed.

@damienmg
Copy link
Contributor

LGTM if it's ok with @kchodorow

@kchodorow
Copy link
Contributor

SGTM, I'll merge it in.

bazel-io pushed a commit that referenced this pull request Jan 26, 2016
Apropos issue #776. This hint in the doc would have saved me from filing a bogus bug.

--
Reviewed-on: #778
MOS_MIGRATED_REVID=112972220
@damienmg
Copy link
Contributor

This was merged

@damienmg damienmg closed this Jan 27, 2016
steren pushed a commit to bazelbuild/bazel-website that referenced this pull request Apr 26, 2017
Apropos issue #776. This hint in the doc would have saved me from filing a bogus bug.

--
Reviewed-on: bazelbuild/bazel#778
MOS_MIGRATED_REVID=112972220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants