Link to Maven coordinates in the maven_jar documentation. #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Maven coordinates can be more sophisticated than we want to document here (alternate packaging/classifiers).
dfabulich
force-pushed
the
dgf-mavenCoords
branch
from
12692f5
to
d1e58aa
Compare
|
CLAs look good, thanks! |
|
LGTM, I'll merge it in. Thanks for the contribution! |
bazel-io
pushed a commit
that referenced
this pull request
Feb 9, 2016
[Maven coordinates](https://maven.apache.org/pom.html#Maven_Coordinates) can be more sophisticated than we want to document here (alternate packaging/classifiers). Specifically, I needed to link to `json-lib-2.4-jdk15.jar` at https://repo1.maven.org/maven2/net/sf/json-lib/json-li[].4/json-lib-2.4-jdk15.jar. In Maven, you'd refer to that like this: ``` <dependency> <groupId>net.sf.json-lib</groupId> <artifactId>json-lib</artifactId> <version>2.4</version> <classifier>jdk15</classifier> </dependency> ``` It turns out that this works great in Bazel, too, if you use Maven coordinates. ``` maven_jar ( name = "net.sf.json-lib_json-lib", artifact = "net.sf.json-lib:json-lib:jar:jdk15:2.4", ) ``` But it took me some effort to find it. Adding this link would have helped me, and will probably help somebody else, too. -- Reviewed-on: #856 MOS_MIGRATED_REVID=114135334
|
This was merged, thanks again for your contribution! |
luca-digrazia
pushed a commit
to luca-digrazia/DatasetCommitsDiffSearch
that referenced
this pull request
Sep 5, 2022
[Maven coordinates](https://maven.apache.org/pom.html#Maven_Coordinates) can be more sophisticated than we want to document here (alternate packaging/classifiers). Specifically, I needed to link to `json-lib-2.4-jdk15.jar` at https://repo1.maven.org/maven2/net/sf/json-lib/json-li[].4/json-lib-2.4-jdk15.jar. In Maven, you'd refer to that like this: ``` <dependency> <groupId>net.sf.json-lib</groupId> <artifactId>json-lib</artifactId> <version>2.4</version> <classifier>jdk15</classifier> </dependency> ``` It turns out that this works great in Bazel, too, if you use Maven coordinates. ``` maven_jar ( name = "net.sf.json-lib_json-lib", artifact = "net.sf.json-lib:json-lib:jar:jdk15:2.4", ) ``` But it took me some effort to find it. Adding this link would have helped me, and will probably help somebody else, too. -- Reviewed-on: bazelbuild/bazel#856 MOS_MIGRATED_REVID=114135334
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maven coordinates can be more sophisticated than we want to document here (alternate packaging/classifiers).
Specifically, I needed to link to
json-lib-2.4-jdk15.jarat https://repo1.maven.org/maven2/net/sf/json-lib/json-lib/2.4/json-lib-2.4-jdk15.jar. In Maven, you'd refer to that like this:It turns out that this works great in Bazel, too, if you use Maven coordinates.
But it took me some effort to find it. Adding this link would have helped me, and will probably help somebody else, too.