Teach cc_configure about BAZEL_LINKLIBS env variable #8660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this variable is will be possible to specify system libraries that should
be added after default linker flags, after libraries to link, and after user
link flags (i.e. --linkopt and `linkopts` rule attribute).
Flag separator is `:`, similarly to BAZEL_LINKOPTS. Escaping is done by `%`.
Default value is empty string.
With this it's possible to force Bazel to statically link libstdc++ by using:
BAZEL_LINKOPTS=-static-libstdc++ BAZEL_LINKLIBS=-l%:libstdc++.a bazel build //foo
RELNOTES: Bazel's C++ autoconfiguration now understands BAZEL_LINKLIBS
GOOGLE:
scentini
suggested changes
Jun 18, 2019
| @@ -854,6 +854,9 @@ def _impl(ctx): | |||
| iterate_over = "user_link_flags", | |||
| expand_if_available = "user_link_flags", | |||
| ), | |||
| flag_group( | |||
There was a problem hiding this comment.
flag_group must have one of flag_groups and flags nonempty, which will make Bazel complain in case ctx.attr.link_libs is empty.
There was a problem hiding this comment.
Interview question :) Why was @hlopko never supposed to be hired? https://source.bazel.build/bazel/+/fa654b4878974e591d7e0bea3fa233c6b120395b:tools/cpp/lib_cc_configure.bzl;l=47
There was a problem hiding this comment.
Ha, I'm not stupid, maybe. Ignore this.
scentini
approved these changes
Jun 18, 2019
siberex
pushed a commit
to siberex/bazel
that referenced
this pull request
Jul 4, 2019
Using this variable is will be possible to specify system libraries that should be added after default linker flags, after libraries to link, and after user link flags (i.e. after --linkopt and `linkopts` rule attribute). Flag separator is `:`, similarly to `BAZEL_LINKOPTS`. Escaping is done by `%`. Default value is empty string. With this it's possible to force Bazel to statically link `libstdc++` by using: ``` BAZEL_LINKOPTS=-static-libstdc++ BAZEL_LINKLIBS=-l%:libstdc++.a bazel build //foo ``` Fixes bazelbuild#2840. Relevant for bazelbuild#8652. RELNOTES: Bazel's C++ autoconfiguration now understands `BAZEL_LINKLIBS` environment variable to specify system libraries that should be appended to the link command line. Closes bazelbuild#8660. PiperOrigin-RevId: 253946433
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jul 15, 2019
Using this variable is will be possible to specify system libraries that should be added after default linker flags, after libraries to link, and after user link flags (i.e. after --linkopt and `linkopts` rule attribute). Flag separator is `:`, similarly to `BAZEL_LINKOPTS`. Escaping is done by `%`. Default value is empty string. With this it's possible to force Bazel to statically link `libstdc++` by using: ``` BAZEL_LINKOPTS=-static-libstdc++ BAZEL_LINKLIBS=-l%:libstdc++.a bazel build //foo ``` Fixes bazelbuild#2840. Relevant for bazelbuild#8652. RELNOTES: Bazel's C++ autoconfiguration now understands `BAZEL_LINKLIBS` environment variable to specify system libraries that should be appended to the link command line. Closes bazelbuild#8660. PiperOrigin-RevId: 253946433
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this variable is will be possible to specify system libraries that
should be added after default linker flags, after libraries to link, and
after user link flags (i.e. after --linkopt and
linkoptsrule attribute).Flag separator is
:, similarly toBAZEL_LINKOPTS. Escaping is done by%.Default value is empty string.
With this it's possible to force Bazel to statically link
libstdc++byusing:
Fixes #2840.
Relevant for #8652.
RELNOTES: Bazel's C++ autoconfiguration now understands
BAZEL_LINKLIBSenvironment variable to specify system libraries that should be appended to the link command line.