Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Apple Silicon #272

Merged
merged 7 commits into from Mar 2, 2022
Merged

Added support for Apple Silicon #272

merged 7 commits into from Mar 2, 2022

Conversation

linzhp
Copy link
Contributor

@linzhp linzhp commented Oct 6, 2021

Bazelish should check the Bazel version. If it is greater or equal to than 4.1, add support for arm64 so we can run Bazel on Apple Sillicon. Fixed #270

@mindaugasrukas
Copy link

mindaugasrukas commented Oct 6, 2021

LGTM. Works on my M1 machine.

$ bazel --version
bazel 4.2.1

$ uname -p -r -s -m
Darwin 20.6.0 arm64 arm

@linzhp linzhp changed the title Added support for Apple Sillicon Added support for Apple Silicon Oct 26, 2021
@linzhp
Copy link
Contributor Author

linzhp commented Jan 30, 2022

ping @philwo

Copy link
Member

@philwo philwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

philwo
philwo previously requested changes Feb 1, 2022
Copy link
Member

@philwo philwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, found two little things to change - could you have a look?

bazelisk.py Outdated Show resolved Hide resolved
bazelisk.py Outdated Show resolved Hide resolved
@linzhp
Copy link
Contributor Author

linzhp commented Mar 1, 2022

@fweikert I believe the current CI errors are transient issues. It can be fixed by restarting the job, but I don't have the permission to do so.

bazelisk.py Outdated Show resolved Hide resolved
bazelisk.py Outdated Show resolved Hide resolved
bazelisk.py Show resolved Hide resolved
@linzhp
Copy link
Contributor Author

linzhp commented Mar 2, 2022

@fweikert addressed your comments. All tests passed.

@fweikert fweikert merged commit 31d0d7e into bazelbuild:master Mar 2, 2022
@linzhp linzhp deleted the m1 branch March 2, 2022 18:35
gcf-merge-on-green bot pushed a commit to googleapis/gapic-generator-typescript that referenced this pull request Jul 22, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@bazel/bazelisk](https://togithub.com/bazelbuild/bazelisk) | [`^1.11.0` -> `^1.12.0`](https://renovatebot.com/diffs/npm/@bazel%2fbazelisk/1.11.0/1.12.0) | [![age](https://badges.renovateapi.com/packages/npm/@bazel%2fbazelisk/1.12.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@bazel%2fbazelisk/1.12.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@bazel%2fbazelisk/1.12.0/compatibility-slim/1.11.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@bazel%2fbazelisk/1.12.0/confidence-slim/1.11.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>bazelbuild/bazelisk</summary>

### [`v1.12.0`](https://togithub.com/bazelbuild/bazelisk/releases/tag/v1.12.0)

[Compare Source](https://togithub.com/bazelbuild/bazelisk/compare/v1.11.0...v1.12.0)

This release brings new features and fixes to both versions of Bazelisk:

Go:

-   Added support for basic HTTP authentication via a .netrc file ([bazelbuild/bazelisk#292)
-   Improved and fixed Apple Silicon support ([bazelbuild/bazelisk#299, [bazelbuild/bazelisk#303)
-   Rolling releases are now fetched from GCS instead of GitHub ([bazelbuild/bazelisk#319)

Python:

-   Added support for Apple Silicon ([bazelbuild/bazelisk#272)
-   Implemented verification of downloaded Bazel binaries ([bazelbuild/bazelisk#295)

We'd like to thank our contributors [@&#8203;chenrui333](https://togithub.com/chenrui333), [@&#8203;codeman9](https://togithub.com/codeman9), [@&#8203;cpsauer](https://togithub.com/cpsauer), [@&#8203;keith](https://togithub.com/keith), [@&#8203;linzhp](https://togithub.com/linzhp), [@&#8203;Warchant](https://togithub.com/Warchant) and [@&#8203;xinnjie](https://togithub.com/xinnjie)!

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-typescript).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMjIuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEyMi4xIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bazelisk.py does not support Apple arm64
4 participants