Add support for patch versions of Bazel (e.g. 1.2.3-patch4)
#280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philwo
approved these changes
Nov 20, 2021
|
@fweikert Didn't realize there was a merge conflict here. That's been resolved and this PR is ready for a review if you can find the time 🙏 |
|
Sorry, I've been OOO for two weeks. Will take a look later today |
fweikert
reviewed
Dec 8, 2021
| @@ -18,6 +18,7 @@ const ( | |||
|
|
|||
| var ( | |||
| releasePattern = regexp.MustCompile(`^(\d+)\.(x|\d+\.\d+)$`) | |||
| patchPattern = regexp.MustCompile(`^(\d+\.\d+\.\d+)-([\w\d]+)$`) | |||
There was a problem hiding this comment.
I think we should start with a more restrictive regex and then maybe loosen it later. what about ...-patch\d+
?
There was a problem hiding this comment.
Restricting it to just -patch would not satisfy my needs unfortunately 😞 Do you feel strongly that it should be restrictive?
fweikert
approved these changes
Dec 8, 2021
|
Thank you so much! Do you know when the next release will be? |
|
We can cut a new one this week. |
|
Update: I released v1.11.0 yesterday, including this change. |
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some patches I maintain in a fork of Bazel and generate binaries with
-patchsuffixes followed by a number (e.g.4.2.1-patch1) and would like to start using Bazelisk to download those binaries. This mostly works already except that Bazelisk does not accept the-patchpatch versions. The change is pretty small so thought I'd open a pull requests to learn whether or not this patching pattern was a good idea or if maybe there's a better way. I also understand not everyone may be doing this so am open to other ideas and approaches for using patched Bazel versions.