Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish gh release binaries #44

Closed
softprops opened this issue Jan 28, 2017 · 14 comments
Closed

Publish gh release binaries #44

softprops opened this issue Jan 28, 2017 · 14 comments
Assignees

Comments

@softprops
Copy link

I'd like my team to use this tool without forcing them all to install the go runtime

@pmbethe09 pmbethe09 self-assigned this Jan 30, 2017
@pmbethe09
Copy link
Member

When #45 lands, I will make a tag and a companion release

@softprops
Copy link
Author

Sweet.

@pmbethe09
Copy link
Member

I added Mac and linux64 builds -- hopefully that is enough?

@bolinfest
Copy link
Contributor

Personally, I also need this on Windows.

@softprops
Copy link
Author

Mac is perfect for me. Linux will be great for ci validation. Thanks @pmbethe09!

@pmbethe09
Copy link
Member

I don't have a good way to make a Windows release -- let me ask the bazel team for suggestions

@softprops
Copy link
Author

looks like the links for the OSX release bins are invalid here https://github.com/bazelbuild/buildifier/releases. is this the right place to look?

@pmbethe09
Copy link
Member

pmbethe09 commented Feb 6, 2017 via email

@bolinfest
Copy link
Contributor

@pmbethe09 The OSX release worked for me, but the Linux one claims that it does not support the -tables flag. Are you sure you built it from the correct commit?

@pmbethe09
Copy link
Member

... No not sure. We need a better release process as these were ad-hoc.
I have updated to fresh builds.

@bolinfest
Copy link
Contributor

@pmbethe09 You might be able to have Circle-CI do the build and publish it for you. That's what we do for Nuclide, and the setup does not appear to be npm/apm specific: https://github.com/facebook/nuclide/blob/master/circle.yml. (Though maybe it is because somewhere we have to provide our credentials to publish on our behalf to npm...)

Also, FWIW, have you just been changing the binaries under the release tag rather than stamping out a new release with its own version number? It feels a little dodgy to just change the binaries in-place.

@pmbethe09
Copy link
Member

Yes, but only because I didn't know what I was doing -- no more changes as of now :)

@bolinfest
Copy link
Contributor

No worries: I'm sure 0.4.4 will go much smoother!

@pmbethe09
Copy link
Member

closing as automation and Windows are covered in other issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants