Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--lint=warn should have non-zero exit code when there are warnings #470

Closed
alexeagle opened this issue Dec 5, 2018 · 2 comments
Closed

--lint=warn should have non-zero exit code when there are warnings #470

alexeagle opened this issue Dec 5, 2018 · 2 comments

Comments

@alexeagle
Copy link
Contributor

I want to configure my CI to prevent contributors from adding code that has bazel lint warnings.

Currently buildifier --lint=warn exits zero whether or not there are warnings. That makes it impossible to get a red build when a PR introduces a lint warning.
@keith
Copy link
Member

keith commented Dec 5, 2018

I believe I fixed this on master #460 if you are still seeing issues let me know!

@alexeagle
Copy link
Contributor Author

I see, it's just not released yet
0.19.2.1...master

Thanks!!

@laurentlb laurentlb mentioned this issue Feb 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexeagle @keith