Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildozer: make ellipsis work with BUILD.bazel and BUCK files #116

Merged
merged 1 commit into from Jun 23, 2017

Conversation

swolchok
Copy link
Contributor

Fixes #91.

Regarding CLA, this contribution is being made on behalf of my employer, Facebook.

@bazel-io
Copy link
Member

Can one of the admins verify this patch?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@@ -692,8 +700,13 @@ func rewrite(commandsForFile commandsForFile) *rewriteResult {
}
} else {
origName := name
name = strings.TrimSuffix(name, "BUILD")
for _, suffix := range buildFileSuffixes {
for suffix := range buildFileNames {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem with this change is the intentionally random iteration order of Go maps.

You probably need to keep the list for this part and the map for below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I forgot that the iteration order mattered.

@swolchok
Copy link
Contributor Author

should be fixed!

@pmbethe09
Copy link
Member

Jenkins, test this please.

@pmbethe09
Copy link
Member

LGTM, just waiting for CI

@pmbethe09 pmbethe09 merged commit fe4721c into bazelbuild:master Jun 23, 2017
@swolchok swolchok deleted the buildozer-ellipsis branch October 8, 2017 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants