New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildozer: make ellipsis work with BUILD.bazel and BUCK files #116
Conversation
Can one of the admins verify this patch? |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
edit/buildozer.go
Outdated
@@ -692,8 +700,13 @@ func rewrite(commandsForFile commandsForFile) *rewriteResult { | |||
} | |||
} else { | |||
origName := name | |||
name = strings.TrimSuffix(name, "BUILD") | |||
for _, suffix := range buildFileSuffixes { | |||
for suffix := range buildFileNames { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem with this change is the intentionally random iteration order of Go maps.
You probably need to keep the list for this part and the map for below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, I forgot that the iteration order mattered.
fc53a04
to
bfaedf9
Compare
should be fixed! |
Jenkins, test this please. |
LGTM, just waiting for CI |
Fixes #91.
Regarding CLA, this contribution is being made on behalf of my employer, Facebook.