Rewrite status.sh in Python #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fweikert PTAL, do I need to do anything else with the script? |
|
That's not covered by tests (because |
laurentlb
approved these changes
May 15, 2019
lucamilanesio
pushed a commit
to GerritCodeReview/gerrit-ci-scripts
that referenced
this pull request
Jun 14, 2019
Workspace status command was re-written in Python in: [1]. [1] bazelbuild/buildtools#631 Change-Id: I891f1a0c51a9f76ecd4a045debdbce92a0c02877
cristiancreteanu
pushed a commit
to cristiancreteanu/buildtools
that referenced
this pull request
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
status.shis used by BazelCI to build buildtools-related binaries, but it can't be used on Windows.status.pyis a multiplatform alternative, it will completely replacestatus.shonce the latter is not used anymore by the CI configuration.#375