Skip to content

Commit

Permalink
Add a note about incremental incorrectness in rbe_repo.bzl (#1726)
Browse files Browse the repository at this point in the history
  • Loading branch information
hvadehra committed Feb 7, 2024
1 parent fc64f29 commit c89f292
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions rules/rbe_repo.bzl
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
"""Defines the rbe_preconfig rule for Bazel CI
Note: this implementation is deliberately incrementally-incorrect. The
same manifest.json file is overwritten with new configurations, and we don't
validate it's checksum. A clean build / re-sync is required to pick up the changes.
"""

def _available_bazel_versions(manifests):
bazel_versions = []
for manifest in manifests:
Expand Down Expand Up @@ -48,11 +55,12 @@ def _rbe_preconfig_impl(repository_ctx):

toolchain_name = repository_ctx.attr.toolchain

manifest_json = 'manifest.json'
manifest_json = "manifest.json"

# Omit sha256 since remote file can be changed
repository_ctx.download(
output = manifest_json,
url = ["https://storage.googleapis.com/bazel-ci/rbe-configs/manifest.json"]
url = ["https://storage.googleapis.com/bazel-ci/rbe-configs/manifest.json"],
)

manifests = json.decode(repository_ctx.read(manifest_json))
Expand Down

0 comments on commit c89f292

Please sign in to comment.