Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rules_dotnet to the CI #312

Closed
laurentlb opened this issue Aug 23, 2018 · 6 comments · Fixed by #1127
Closed

Add rules_dotnet to the CI #312

laurentlb opened this issue Aug 23, 2018 · 6 comments · Fixed by #1127
Labels
new-project For requests to add a new project to Bazel CI P2

Comments

@laurentlb
Copy link
Contributor

https://github.com/bazelbuild/rules_dotnet
@fweikert
Copy link
Member

The rules_dotnet pipeline was added in September 2018 (at least its first build has that timestamp), but I don't see any recent activity. I guess that the repo owners didn't set up the webhook.

@laurentlb
Copy link
Contributor Author

I don't see it in https://buildkite.com/bazel/bazel-at-head-plus-downstream

What should owners do? Do we have any link to documentation?
(cc @tomaszstrejczek)

@fweikert fweikert reopened this Feb 26, 2019
@fweikert
Copy link
Member

Ok, there is a misunderstanding: We already have a pipeline for rules_dotnet, but it hasn't been tested as part of the downstream pipeline.

I'll open a PR.

fweikert added a commit to fweikert/continuous-integration that referenced this issue Feb 26, 2019
@fweikert
Add rules_dotnet to downstream pipeline.
9126863 
However, we should wait before submitting this fix: The rules_dotnet pipeline has been stale for several months, and a manual build failed on all platforms (https://buildkite.com/bazel/rules-dotnet-edge/builds/6).
The team should properly set up the GitHub webhook and then fix their tests.

Fixes bazelbuild#312.
@fweikert fweikert mentioned this issue Feb 26, 2019
Closed
@fweikert
Copy link
Member

I have a fix, but it doesn't make much sense to merge is now: The rules_dotnet pipeline is completely stale (no build in recent months), and a manually triggered build failed completely. The rules_dotnet team should properly set up the GitHub webhook and then fix their tests.

@tomaszstrejczek
Copy link

tomaszstrejczek commented Feb 26, 2019 via email

@philwo philwo added new-project For requests to add a new project to Bazel CI P2 labels May 28, 2019
fweikert added a commit that referenced this issue Mar 30, 2021
@fweikert
Add rules_dotnet to downstream pipeline (2nd try)
55d456f 
This PR is a revival of #504. At the time we decided to NOT merge the PR since the pipeline had been broken for quite some time.
However, this has now changed, as the pipeline is stable and has been green for several weeks: https://buildkite.com/bazel/rules-dotnet-edge/builds?branch=master

Fixes #312
@fweikert fweikert mentioned this issue Mar 30, 2021
Merged
@fweikert
Copy link
Member

Pipeline looks good, so I'll go ahead and add it to the downstream pipeline.

fweikert added a commit that referenced this issue Apr 1, 2021
@fweikert
Add rules_dotnet to downstream pipeline (2nd try) (#1127)
5569c11 
This PR is a revival of #504. At the time we decided to NOT merge the PR since the pipeline had been broken for quite some time.
However, this has now changed, as the pipeline is stable and has been green for several weeks: https://buildkite.com/bazel/rules-dotnet-edge/builds?branch=master

Fixes #312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new-project For requests to add a new project to Bazel CI P2
Projects
None yet
Milestone
No milestone
4 participants
@laurentlb @philwo @tomaszstrejczek @fweikert