Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix publish_binary for Linux #1915

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Fix publish_binary for Linux #1915

merged 1 commit into from
Mar 12, 2024

Conversation

meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy commented Mar 12, 2024 •
edited
Loading

Change back to ubuntu1404 to not break existing users, which was changed to ubuntu2004 in c781266

@meteorcloudy
Fix publish_binary for Linux
7d76374 
Change back to `ubuntu1404` to not break existing users.
coeuvre
coeuvre approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also need to upgrade jdk in ubuntu1404?

@meteorcloudy
Copy link
Member Author

No, we are not actually building on ubuntu1404 anymore. It's only used in the GCS path where we publish the Bazel binaries, which other tool might depend on.

@meteorcloudy meteorcloudy merged commit cebc329 into master Mar 12, 2024
7 checks passed
@meteorcloudy meteorcloudy deleted the meteorcloudy-patch-1 branch March 12, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coeuvre coeuvre coeuvre approved these changes

@fweikert fweikert Awaiting requested review from fweikert fweikert is a code owner

@Wyverald Wyverald Awaiting requested review from Wyverald Wyverald is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@meteorcloudy @coeuvre