Automatically identify targets on import #4
Labels
product: IntelliJ
IntelliJ plugin
Comments
|
@brendandouglas should we close this given your work on deriving targets from directories? |
|
Yes, I think this is basically solved now. I'd definitely recommend all users derive targets from directories automatically. We'll likely need further refinements for this, so if people notice issues with the feature, please let us know -- I'm always interested in improving it. |
copybara-service bot
pushed a commit
that referenced
this issue
May 15, 2020
…ient_java as a runtime_deps to intellij_plugin. This change grandfathers the affected targets into the "UseFlags" modes of mendel options (go/mendel-design-java-options), meaning they get their Mendel configuration from command line flags. We will migrate these clients to use options in the future. After this LSC new clients will automatically use options. This CL contains step (1) of 2 changes: 1. Add a new attrbute, extra_runtime_deps to intellij_plugin and set runtime_deps on java_binary and java_test with this value. 2. Set extra_runtime_deps = "//java/com/google/experiments/framework/options:grandfathered_client_java" on all intellij_plugin from third_party/intellij/plugin/build_defs/intellij_plugin.bzl calls that use mendel. This particular change covers case #4 in go/mendel-proposal-modifying-macros-for-grandfathering-java-options, because intellij_plugin does not support runtime_deps. The CL was created from experimental/users/jpalm/bugs/154487466_use_flags_non_boq/modify_generator_functions.sh. More information: go/google3-lsc-useflags-for-non-boq-java APPROVALS_REQUIRED=True CLEANUP=error-prone GENERATOR_FUNCTION=intellij_plugin GENERATOR_FUNCTION_FILE=third_party/intellij/plugin/build_defs/intellij_plugin.bzl MASTER_CL=311644400 MENDEL_JAVA_OPTIONS=Step4 PiperOrigin-RevId: 311652221
copybara-service bot
pushed a commit
that referenced
this issue
May 15, 2020
…ient_java as a runtime_deps to intellij_plugin. This change grandfathers the affected targets into the "UseFlags" modes of mendel options (go/mendel-design-java-options), meaning they get their Mendel configuration from command line flags. We will migrate these clients to use options in the future. After this LSC new clients will automatically use options. This CL contains step (1) of 2 changes: 1. Add a new attrbute, extra_runtime_deps to intellij_plugin and set runtime_deps on java_binary and java_test with this value. 2. Set extra_runtime_deps = "//java/com/google/experiments/framework/options:grandfathered_client_java" on all intellij_plugin from third_party/intellij/plugin/build_defs/intellij_plugin.bzl calls that use mendel. This particular change covers case #4 in go/mendel-proposal-modifying-macros-for-grandfathering-java-options, because intellij_plugin does not support runtime_deps. The CL was created from experimental/users/jpalm/bugs/154487466_use_flags_non_boq/modify_generator_functions.sh. More information: go/google3-lsc-useflags-for-non-boq-java APPROVALS_REQUIRED=True CLEANUP=error-prone GENERATOR_FUNCTION=intellij_plugin GENERATOR_FUNCTION_FILE=third_party/intellij/plugin/build_defs/intellij_plugin.bzl MASTER_CL=311644400 MENDEL_JAVA_OPTIONS=Step4 PiperOrigin-RevId: 311652221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently when importing a project the plugin suggests
//...:allor manually specifying the targets. Pants intellij plugin automatically identifies the targets and enables you to checkbox which of the existing targets you want to be added to your project view.I think this can be a great feature (just give a bit more real-estate for selecting the targets 😉)
The text was updated successfully, but these errors were encountered: