Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use third_party jarjar. #2218

Closed
wants to merge 5 commits into from
Closed

Conversation

comius
Copy link
Contributor

@comius comius commented Nov 18, 2020

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #2219

Description of this change

Uses its own dependency on jarjar, because jarjar is not shipped with Bazel anymore.

@google-cla google-cla bot added the cla: yes label Nov 18, 2020
@comius comius marked this pull request as ready for review November 18, 2020 13:33
@comius
Copy link
Contributor Author

comius commented Nov 23, 2020

friendly ping

copybara-service bot pushed a commit that referenced this pull request Dec 4, 2020
Imported from #2218 with minor
changes.

PiperOrigin-RevId: 345717903
copybara-service bot pushed a commit that referenced this pull request Dec 4, 2020
Imported from #2218 with minor changes.

PiperOrigin-RevId: 345717903
copybara-service bot pushed a commit that referenced this pull request Dec 4, 2020
Imported from #2218 with minor changes.

PiperOrigin-RevId: 345717903
copybara-service bot pushed a commit that referenced this pull request Dec 4, 2020
Imported from #2218.

PiperOrigin-RevId: 345717903
copybara-service bot pushed a commit that referenced this pull request Dec 4, 2020
Imported from #2218.

PiperOrigin-RevId: 345717903
copybara-service bot pushed a commit that referenced this pull request Dec 4, 2020
Imported from #2218.

PiperOrigin-RevId: 345717903
copybara-service bot pushed a commit that referenced this pull request Dec 4, 2020
Imported from #2218.

PiperOrigin-RevId: 345717903
copybara-service bot pushed a commit that referenced this pull request Dec 5, 2020
Imported from #2218.

PiperOrigin-RevId: 345717903
copybara-service bot pushed a commit that referenced this pull request Dec 7, 2020
Imported from #2218.

PiperOrigin-RevId: 345717903
copybara-service bot pushed a commit that referenced this pull request Dec 7, 2020
Imported from #2218.

PiperOrigin-RevId: 345717903
copybara-service bot pushed a commit that referenced this pull request Dec 7, 2020
Imported from #2218.

PiperOrigin-RevId: 346086031
@alice-ks
Copy link
Collaborator

Thanks for this pull request. We imported it and used it as base for #2242.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants