Fix IntellijAspectTest to recognize both "//foo:bar" and "@//foo:bar" labels #3779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
… labels Both mean the same thing in a monorepo, but only the latter is unambiguous, since the former could mean different things from different repos. Bazel will generate the latter for absolute labels in the main repo in a future release, and this change is forwards-compatible with that. See bazelbuild/bazel#15916 for more information. PiperOrigin-RevId: 462117644
|
IIUC this change was still incorrect for some cases that is why the PR was closed and a different workaround was implemented in 41d1964. Can you please open an issue for the problem you are seeing with Android Studio plugin recently? |
|
nvm we tried the latest plugin and it seems like it's fixed already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix IntellijAspectTest to recognize both "//foo:bar" and "@//foo:bar" labels
Both mean the same thing in a monorepo, but only the latter is unambiguous, since the former could mean different things from different repos. Bazel will generate the latter for absolute labels in the main repo in a future release, and this change is forwards-compatible with that.
See bazelbuild/bazel#15916 for more information.