Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove javacopt from bazelrc #5194

Closed
wants to merge 1 commit into from
Closed

Conversation

idanakav
Copy link
Contributor

@idanakav idanakav commented Aug 2, 2023

We have some usage (example) of Java features which are not compatible with Java8, yet we still specify java 8 for both source and target javac options in the bazelrc.

Unless specified to override those, the build is failing:

bazel build //aswb:aswb_bazel_zip --define=ij_product=android-studio-canary
...
...
aswb/sdkcompat/as231/com/google/idea/blaze/android/run/runner/BlazeAndroidDebuggerService.java:132: error: private interface methods are not supported in -source 8
  private static boolean isNdkPluginLoaded() {
                                          ^
  (use -source 9 or higher to enable private interface methods)

@idanakav
Copy link
Contributor Author

idanakav commented Aug 2, 2023

Apparently this will cause issues when the plugin is running the aspects, with this change the apsects will only run with Java17, maybe targeting java 11 is a possibility.

@mai93
Copy link
Collaborator

mai93 commented Aug 2, 2023

I think I fixed this in 47f9f20, we need to cherry-pick it to the master branch.

Cherry-picked to master branch: 89e9f9a

@idanakav
Copy link
Contributor Author

idanakav commented Aug 2, 2023

ty @mai93 , this can be closed then.

@idanakav idanakav closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants