Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BUILD.bazel files along BUILDin errors parsing #5206

Merged

Conversation

dkashyn-sfdc
Copy link
Contributor

@dkashyn-sfdc dkashyn-sfdc commented Aug 6, 2023

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

According to https://bazel.build/concepts/build-files

Note: The BUILD file can be named either BUILD or BUILD.bazel. If both files exist, BUILD.bazel takes precedence over BUILD. For simplicity's sake, the documentation refers to these files simply as BUILD files.

So we need to parse them both in the error output. Before the fix BUILD.bazel errors have neither file nor line number so not clickable.

@github-actions github-actions bot added product: Android Studio Android Studio plugin product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Aug 6, 2023
@dkashyn-sfdc
Copy link
Contributor Author

Before and after
image

@tpasternak tpasternak requested review from tpasternak and mai93 and removed request for mai93 August 9, 2023 11:24
@tpasternak tpasternak assigned tpasternak and unassigned mai93 Aug 9, 2023
@tpasternak
Copy link
Collaborator

Oh no, sorry @dkashyn-sfdc it's my fault. Wrong email in commit message. Please force push previous change at we will merge it as is. I'll apply my changes later on

Copy link
Collaborator

@tpasternak tpasternak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dkashyn-sfdc

@dkashyn-sfdc dkashyn-sfdc force-pushed the bazel-build-file-errors-parsing branch from 537bb9e to 1d2776a Compare August 9, 2023 12:15
@tpasternak tpasternak merged commit 95ca4cf into bazelbuild:master Aug 9, 2023
6 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: Android Studio Android Studio plugin product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants