Adapt paths and line breaks for Windows

[ahmedyarub]

Fix typos

Checklist

• I have filed an issue about this change and discussed potential changes with the maintainers.
• I have received the approval from the maintainers to make this change.
• This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: 5470

Description of this change

Fix directory separators and line-breaks on Windows, and fix some typos.

Closes #5470

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[sgowroji]

Hi @ahmedyarub, Could you please sign the CLA?

[tpasternak]

I would run both replacements conditionally, only for non-WSL WIndows. In unix systems you can have backslash in a filename (try mkdir a\\b).

Same story for \r, just because it's not required outside Windows

[agluszak]

I would run both replacements conditionally, only for non-WSL WIndows. In unix systems you can have backslash in a filename (try mkdir a\\b).

Same story for \r, just because it's not required outside Windows

Good catch

[ahmedyarub]

I would run both replacements conditionally, only for non-WSL WIndows. In unix systems you can have backslash in a filename (try mkdir a\\b).

Same story for \r, just because it's not required outside Windows

Made the changes by copying the checks from other parts of the code. I couldn't find a specific check for WSL. It seems to me that SystemInfo.isWindows is enough.

[ahmedyarub]

Do I need to add anything here?

[blorente]

Thanks for adding the changes!
Please note that CI doesn't run on Windows, so it might break in the future.

[ahmedyarub]

Thanks for adding the changes! Please note that CI doesn't run on Windows, so it might break in the future.

Just tag me anytime a bug is reported and I'll make sure to fix it ASAP. I appreciate this great project really!